Skip to content

Conversation

@imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Dec 9, 2025

Description

Scope: core

Type of change: feat

Content description: TODO

to fix: 3-links updates arent done properly, there is an offset to fix
it is disabled by default and can be enabled via the new method of `CMapBuilder`,
`enable_vertex_id_cache`
perf isnt worse, we're just hitting an error infinitely. the case isnt
covered by tests so idk where it comes from
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 72.17631% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.65%. Comparing base (4cf98c7) to head (ddb0971).

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/dim3/links/three.rs 47.94% 38 Missing ⚠️
honeycomb-core/src/cmap/dim3/sews/three.rs 47.36% 20 Missing ⚠️
honeycomb-core/src/cmap/dim3/links/one.rs 68.18% 14 Missing ⚠️
honeycomb-core/src/cmap/dim3/utils.rs 30.76% 9 Missing ⚠️
honeycomb-core/src/cmap/dim3/links/two.rs 95.19% 5 Missing ⚠️
honeycomb-core/src/cmap/builder/structure.rs 63.63% 4 Missing ⚠️
honeycomb-kernels/src/grid_generation/mod.rs 63.63% 4 Missing ⚠️
honeycomb-core/src/cmap/dim3/structure.rs 83.33% 3 Missing ⚠️
honeycomb-core/src/cmap/builder/io.rs 0.00% 2 Missing ⚠️
honeycomb-core/src/cmap/dim3/sews/two.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   85.86%   85.65%   -0.21%     
==========================================
  Files          75       75              
  Lines       10661    10940     +279     
==========================================
+ Hits         9154     9371     +217     
- Misses       1507     1569      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants