feat: 适配 ARCS 芯片烧录 #11

xf-cai · 2025-05-21T10:51:52Z

1、适配arcs芯片烧录；
2、支持 arcs 6M波特率烧录；
3、支持 emmc 烧录。

xingrz

支持arcs、支持emmc、支持lock/unlock是三个feature，应该分成三个commit（但还是在同一个PR）提交。

其它见review内容。

cskburn/src/main.c

libcskburn_serial/src/core.c

libserial/src/serial_win32.c

libserial/include/serial.h

libserial/src/serial_win32.c

xingrz

如review所示
对PR中的commit的修正应该squash到原本的commit里，避免用一个新的commit反复改动前一个commit的东西

xingrz · 2025-05-22T06:41:56Z

libcskburn_serial/include/cskburn_serial.h

+	CHIP_TYPE_6 = 6,
+	CHIP_TYPE_ARCS,
+	CHIP_TYPE_UNKNOWN = 0xFF,
+} chip_type_t;


我感觉叫 cskburn_serial_chip_t 更能保持一致，并且应该放在 cskburn_serial_target_t 上面；另外，core.h和cskburn_serial_open里的uint32_t也还没改

xingrz · 2025-05-22T06:43:33Z

cskburn/src/main.c

+#define CHIP_TO_STR(chip)                       \
+	((chip) == CHIP_TYPE_3             ? "3"    \
+			: (chip) == CHIP_TYPE_4    ? "4"    \
+			: (chip) == CHIP_TYPE_6    ? "6"    \
+			: (chip) == CHIP_TYPE_ARCS ? "arcs" \
+									   : "unknown")


感觉用 static const char数组更方便后续扩展

xingrz · 2025-05-22T06:46:24Z

libcskburn_serial/src/core.c

 #include "time_monotonic.h"

 #define BAUD_RATE_INIT 115200
+#define MAX_ROM_BAUD_RATE 3000000


BAUD_RATE_MAX

xingrz · 2025-05-22T06:48:36Z

libcskburn_serial/src/core.c

 	}

+	if (chip == CHIP_TYPE_ARCS) {
+		ret = serial_config_rts_state(serial, SERIAL_RTS_OFF);  // enable RTS


为什么传参是OFF，注释反而是enable？需要在注释里简略说明这个调用的作用（会改变什么行为，为什么需要这么做）

xingrz · 2025-05-22T06:51:59Z

libcskburn_serial/src/core.c

 	if (burner != NULL && len > 0) {
+		uint64_t t1 = time_monotonic();
+
 		// For CSK6, CMD_CHANGE_BAUD is supported by the ROM, so take advantage


For CSK6 and ARCS...

xingrz · 2025-05-22T06:52:13Z

libcskburn_serial/src/core.c

 				return ret;
 			}
 		}
-


多删了一行

xingrz · 2025-05-22T06:53:26Z

libcskburn_serial/src/core.c

 		msleep(500);
+
+		uint64_t t2 = time_monotonic();
+		print_time_spent("writing ram loader", t1, t2);


Writing RAM loader

Copilot

Pull Request Overview

This PR implements support for ARCS chip burning by introducing new APIs for configuring RTS/DTR signals, adjusting baud rate limits and memory read sizes, and adding eMMC-specific commands. Key changes include:

Replacing direct port configuration in the Windows serial module with explicit DCB manipulation.
Adding new functions and enums for configuring RTS/DTR states across Win32 and POSIX platforms.
Extending the burner application to support ARCS chips and eMMC targets with associated command updates and option parsing adjustments.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
libserial/src/serial_win32.c	Updated serial_set_speed and read logic using explicit DCB configuration.
libserial/src/serial_posix.c	Introduced serial_config_rts_state and serial_config_dtr_state implementations.
libserial/include/serial.h	Added enums and APIs for RTS/DTR configuration.
libcskburn_serial/src/core.{h,c}	Modified chip type usage and burning logic to support ARCS chips.
libcskburn_serial/src/cmd.{h,c}	Increased FLASH_READ_SIZE and added eMMC command implementations.
libcskburn_serial/include/cskburn_serial.h	Updated chip type enums and added new locking/unlocking APIs.
libcskburn_serial/CMakeLists.txt	Included burner_arcs_img.c in the build.
cskburn/src/utils.{h,c}	Added utility function for address alignment.
cskburn/src/main.c	Enhanced chip type mapping and option parsing to support ARCS and eMMC.

Copilot · 2025-05-23T09:06:53Z

libserial/src/serial_win32.c

-	ret = serial_do_read(dev, buf, count, timeout);
-	if (ret < 0) {
-		return ret;
+			DWORD wait_time = min(10, (DWORD)(timeout - elapsed));


Ensure that the 'min' macro is defined on all targeted Windows platforms; if not, consider defining it or using a more portable alternative to avoid potential compilation issues.

Copilot · 2025-05-23T09:06:53Z

libcskburn_serial/src/core.c

-		serial_set_dtr(dev->serial, SERIAL_HIGH);  // RESET=HIGH
+	if (dev->chip == CHIP_TYPE_ARCS) {
+		if (reset_delay > 0) {
+			serial_set_dtr(dev->serial, !rts_active);  // UPDATE=HIGH


The use of 'SERIAL_HIGH'/'SERIAL_LOW' with serial_set_rts/dtr seems inconsistent with the boolean APIs expected in some modules; consider unifying the API to avoid potential misuse or confusion when managing signal states.

Copilot · 2025-05-23T09:06:54Z

libcskburn_serial/src/cmd.h

 #define RAM_BLOCK_SIZE (2 * 1024)
 #define FLASH_BLOCK_SIZE (4 * 1024)
-#define FLASH_READ_SIZE (64)
+#define FLASH_READ_SIZE (4096)


Add a comment explaining the rationale for increasing FLASH_READ_SIZE from 64 to 4096 to improve read performance, ensuring future maintainers understand the memory and performance trade-offs.

cskburn/src/main.c

xingrz · 2025-05-26T03:10:49Z

libserial/src/serial_win32.c

+#ifndef min
+#define min(a, b) ((a) < (b) ? (a) : (b))
+#endif
+
+#ifndef max
+#define max(a, b) ((a) > (b) ? (a) : (b))
+#endif
+


这两个是在支持ARCS的那条提交里用到的，应该放到那条提交里

Signed-off-by: xychen <[email protected]>

xingrz requested changes May 21, 2025

View reviewed changes

xingrz requested changes May 22, 2025

View reviewed changes

xf-cai force-pushed the feat/arcs branch from 322cedc to 44e1c77 Compare May 22, 2025 07:54

xingrz requested a review from Copilot May 23, 2025 09:06

Copilot AI reviewed May 23, 2025

View reviewed changes

xf-cai force-pushed the feat/arcs branch from 44e1c77 to 171ff11 Compare May 26, 2025 02:45

xingrz reviewed May 26, 2025

View reviewed changes

xf-cai force-pushed the feat/arcs branch 2 times, most recently from 6a1ac44 to 1fc863e Compare May 27, 2025 02:35

xf-cai added 3 commits June 3, 2025 19:27

feat: 支持arcs芯片，burner版本 v1.0.0

7688d86

feat: 支持eMMC烧录

c154945

feat: 支持flash的lock/unlock功能

c57f9f9

xf-cai force-pushed the feat/arcs branch from 1fc863e to c57f9f9 Compare June 3, 2025 11:29

github: 修复 CI 构建

f144a69

Signed-off-by: xychen <[email protected]>

feat: 适配 ARCS 芯片烧录 #11

Are you sure you want to change the base?

feat: 适配 ARCS 芯片烧录 #11

Uh oh!

Conversation

xf-cai commented May 21, 2025

Uh oh!

xingrz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xingrz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants