[Fix] get fresh node prices for paid endpoint calls #860

Ansonhkg · 2025-08-13T14:43:20Z

WHAT

re: we need to call a method to get the current node prices so that we can use those prices on the sessionSigs

There are two getMaxPricesForNodeProduct functions, one is async and another one isn’t.

The issue is that the current implementation in the V8 SDK only uses the helper function without the "intelligent" logic, and the nodePrices is coming from the currentConnectionInfo, the fix here is to replace that line of code to getNodePrices which will internally manage the fetching and caching etc.

Behavioural Tests

Manual log inspection was completed to verify the expected caching behaviour.

Test 1 - Make two concurrent calls to trigger "Local promise is already fetching"

const [res1, res2] = await Promise.all([
  ctx.litClient.chain.ethereum.pkpSign({
    authContext: ctx.aliceEoaAuthContext,
    pubKey: ctx.aliceViemAccountPkp.publicKey,
    toSign: 'Hello, concurrent 1!',
  }),
  ctx.litClient.chain.ethereum.pkpSign({
    authContext: ctx.aliceEoaAuthContext,
    pubKey: ctx.aliceViemAccountPkp.publicKey,
    toSign: 'Hello, concurrent 2!',
  }),
]);

Test 2 - Testing stale cache by first execute within the cache window (3 seconds) and one beyond cache window of 3 seconds

// Wait 1 second (within cache window)
await new Promise(resolve => setTimeout(resolve, 1000));

const res3 = await ctx.litClient.chain.ethereum.pkpSign({
  authContext: ctx.aliceEoaAuthContext,
  pubKey: ctx.aliceViemAccountPkp.publicKey,
  toSign: 'Hello, stale cache!',
});

console.log("=== Testing cache expiry (should fetch new) ===");

// Wait 4 seconds (beyond cache window of 3 seconds)
await new Promise(resolve => setTimeout(resolve, 4000));

const res4 = await ctx.litClient.chain.ethereum.pkpSign({
  authContext: ctx.aliceEoaAuthContext,
  pubKey: ctx.aliceViemAccountPkp.publicKey,
  toSign: 'Hello, expired cache!',
});

… endpoints

…s in pricingContext and enhance logging in priceFeedApi

…eck script

…ns to prevent CI formatting failures

…it errors

…e cause

… git issues - Format README.md to fix code style issues detected by CI - Change NX defaultBase to origin/master for better CI compatibility - Replace nx format:check with npx prettier to avoid git branch dependencies - Add auto-formatting with clear failure messages

- Remove exit 1 after successful auto-formatting - CI will now pass if files can be auto-formatted successfully - Add informational message about auto-formatted changes

packages/networks/src/networks/vNaga/envs/naga-dev/naga-dev.module.ts

packages/networks/src/networks/vNaga/envs/naga-local/naga-local.module.ts

FedericoAmura · 2025-08-13T15:34:18Z

packages/networks/src/networks/vNaga/envs/naga-local/naga-local.module.ts

+      // 1. Generate a key set for the JIT context
      const keySet: KeySet = {};

      for (const url of connectionInfo.bootstrapUrls) {


Can we have this functions in one single place instead of one per network? It will be impossible to maintain this and a slight difference like this comment on a different line will interfere with the IDE telling us the code is in multiple places

Also this makes CRing here in GH infeasible, how can I know there are other places that need this change? This will very quickly lead to impossible to fix bugs across different networks if not unified

re: this functions in one single place instead of one per network?

The issue is that there are still some changes being made to the naga branch (eg, this convo) on the lit-assets, IMO. is not concrete enough yet to create a single shared interface (with an option to override logics) to be implemented. (Of course there are things we can start doing, just not the highest priority yet)

We should definitely handle this in a follow up PR - I have another ticket that I have to sync up with the latest changes on the lit-assets naga develop branch so would be a good place to start

Also, opened a discussion ticket here:
https://linear.app/litprotocol/issue/JSS-37/naga-sdk-unify-shared-logic-with-an-option-to-override-for-all-network

The major differences between the Naga networks is very similar to the Datil- attestations & payment for non-dev networks. @Ansonhkg

This is now resolved in this PR
#864

packages/networks/src/networks/vNaga/envs/naga-test/naga-test.module.ts

FedericoAmura · 2025-08-13T15:39:52Z

packages/networks/src/networks/vNaga/envs/naga-dev/naga-dev.module.ts

+      // 2. Fetch the price feed info
+      const nodePrices = await getNodePrices(
+        {
+          realmId: 1,


Do we need to pass the realmId? If it is hardcoded then let's use a constant in a single place, get it from the chain as it could change, or hardcode it in the request call

This way it will be very complex to find and change when that needs a real value

yea we do - I think we should handle all these with a separate PR for shared helpers and logics etc. This value is ideally be dealt within a network environment based helper.

.prettierignore

#860 (comment)

…itClient and chain manager files

Copilot

Pull Request Overview

This PR updates the node pricing mechanism for paid endpoint calls by replacing static price information with dynamically fetched node prices. The implementation introduces a caching mechanism with intelligent fetching logic to improve performance and ensure fresh pricing data.

Integrates the existing getNodePrices function with caching and deduplication logic into the JIT context creation
Replaces static currentConnectionInfo.priceFeedInfo.networkPrices with dynamically fetched jitContext.nodePrices across all signing operations
Consolidates hardcoded development private keys into a single constant for consistency

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
packages/types/src/lib/v2types.ts	Adds `NodePrices` type definition and includes it in `NagaJitContext`
packages/networks/src/networks/vNaga/envs//naga-.module.ts	Updates JIT context creation to fetch fresh node prices using `getNodePrices`
packages/networks/src/networks/vNaga/LitChainClient/apis/highLevelApis/priceFeed/priceFeedApi.ts	Enhances price feed API with logging and improved type definitions
packages/lit-client/src/lib/LitClient/createLitClient.ts	Updates signing operations to use dynamic node prices from JIT context
packages/constants/src/lib/constants/constants.ts	Adds centralized `DEV_PRIVATE_KEY` constant
Multiple chain manager files	Replaces hardcoded private keys with the centralized constant

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-13T18:06:31Z

packages/networks/src/networks/vNaga/envs/naga-test/naga-test.module.ts

@@ -495,7 +500,21 @@ const networkModuleObject = {
        };
      }

-      return { keySet };
+      // Use read-only account for viewing PKPs


The comment 'Use read-only account for viewing PKPs' is misleading since this account is being used to fetch node prices, not view PKPs. Consider updating the comment to reflect the actual purpose: 'Use read-only account for fetching node prices'.

Suggested change

// Use read-only account for viewing PKPs

// Use read-only account for fetching node prices

Copilot · 2025-08-13T18:06:31Z

packages/networks/src/networks/vNaga/envs/naga-staging/naga-staging.module.ts

@@ -495,7 +500,21 @@ const networkModuleObject = {
        };
      }

-      return { keySet };
+      // Use read-only account for viewing PKPs


The comment 'Use read-only account for viewing PKPs' is misleading since this account is being used to fetch node prices, not view PKPs. Consider updating the comment to reflect the actual purpose: 'Use read-only account for fetching node prices'.

Suggested change

// Use read-only account for viewing PKPs

// Use read-only account for fetching node prices

Copilot · 2025-08-13T18:06:31Z

packages/networks/src/networks/vNaga/envs/naga-local/naga-local.module.ts

@@ -494,7 +499,22 @@ const networkModuleObject = {
          secretKey: nacl.box.keyPair().secretKey,
        };
      }
-      return { keySet };
+
+      // Use read-only account for viewing PKPs


The comment 'Use read-only account for viewing PKPs' is misleading since this account is being used to fetch node prices, not view PKPs. Consider updating the comment to reflect the actual purpose: 'Use read-only account for fetching node prices'.

Suggested change

// Use read-only account for viewing PKPs

// Use read-only account for fetching node prices

Copilot · 2025-08-13T18:06:32Z

packages/networks/src/networks/vNaga/envs/naga-dev/naga-dev.module.ts

@@ -495,7 +500,21 @@ const networkModuleObject = {
        };
      }

-      return { keySet };
+      // Use read-only account for viewing PKPs


The comment 'Use read-only account for viewing PKPs' is misleading since this account is being used to fetch node prices, not view PKPs. Consider updating the comment to reflect the actual purpose: 'Use read-only account for fetching node prices'.

Suggested change

// Use read-only account for viewing PKPs

// Use read-only account for fetching node prices

Copilot · 2025-08-13T18:06:32Z

packages/constants/src/lib/constants/constants.ts

@@ -1428,3 +1428,6 @@ export const SIWE_URI_PREFIX = {

 export type SIWE_URI_PREFIX_TYPE = ConstantKeys<typeof SIWE_URI_PREFIX>;
 export type SIWE_URI_PREFIX_VALUES = ConstantValues<typeof SIWE_URI_PREFIX>;
+
+


The DEV_PRIVATE_KEY constant should include a comment explaining its purpose and that it's the standard Anvil/Hardhat development private key to avoid confusion about security implications.

Suggested change

/**

* Standard Anvil/Hardhat development private key.

* This key is used for local development and testing only.

* It is publicly known and should never be used in production environments.

*/

Copilot · 2025-08-13T18:06:32Z

nx.json

@@ -1,7 +1,7 @@
 {
  "$schema": "./node_modules/nx/schemas/nx-schema.json",
  "affected": {
-    "defaultBase": "main"
+    "defaultBase": "origin/master"


Changing the default base from 'main' to 'origin/master' may cause issues if the repository's primary branch is actually 'main'. Verify that 'master' is the correct primary branch name for this repository.

Suggested change

"defaultBase": "origin/master"

"defaultBase": "main"

Ansonhkg · 2025-08-14T18:30:30Z

merging as per request https://litprotocol.slack.com/archives/C03PJ4JPXKM/p1755196077630569?thread_ts=1755195900.128059&cid=C03PJ4JPXKM

Ansonhkg added 2 commits August 13, 2025 02:10

fix(prices): always getNodePrices prior getting session sigs for paid…

8a1fe73

… endpoints

fix(pricing): replace currentConnectionInfo with jitContext.nodePrice…

8d609e9

…s in pricingContext and enhance logging in priceFeedApi

Ansonhkg requested review from glitch003, hwrdtm, FedericoAmura, MaximusHaximus and Copilot August 13, 2025 14:43

Ansonhkg self-assigned this Aug 13, 2025

Ansonhkg temporarily deployed to Health Check August 13, 2025 14:43 — with GitHub Actions Inactive

Ansonhkg requested a review from DashKash54 August 13, 2025 14:44

fmt

1a7c4fe

Ansonhkg temporarily deployed to Health Check August 13, 2025 14:48 — with GitHub Actions Inactive

Ansonhkg changed the title ~~Feature/jss 34 naga fix getting node prices for session sigs~~ [Fix] get fresh node prices for paid endpoint calls Aug 13, 2025

Ansonhkg added Feature v8 | Naga 🐞 Bug Fix Something isn't working and removed Feature labels Aug 13, 2025

fmt

62d2c7a

Ansonhkg had a problem deploying to Health Check August 13, 2025 14:50 — with GitHub Actions Failure

Ansonhkg temporarily deployed to Health Check August 13, 2025 14:57 — with GitHub Actions Inactive

fix(prettier): remove deprecated jsxBracketSameLine and add format:ch…

8f7fe33

…eck script

Ansonhkg had a problem deploying to Health Check August 13, 2025 15:01 — with GitHub Actions Failure

fix(prettier): ignore network schema files and wrapped-keys-lit-actio…

cef155a

…ns to prevent CI formatting failures

Ansonhkg temporarily deployed to Health Check August 13, 2025 15:17 — with GitHub Actions Inactive

fix(nx): change defaultBase from main to master to fix format:check g…

3c7c92d

…it errors

Ansonhkg had a problem deploying to Health Check August 13, 2025 15:21 — with GitHub Actions Failure

ci(lint): add comprehensive debugging to identify format:check failur…

e164a78

…e cause

Ansonhkg temporarily deployed to Health Check August 13, 2025 15:25 — with GitHub Actions Inactive

Ansonhkg temporarily deployed to Health Check August 13, 2025 15:27 — with GitHub Actions Inactive

fix(ci): allow auto-formatting to pass without failing CI

2ec75a8

- Remove exit 1 after successful auto-formatting - CI will now pass if files can be auto-formatted successfully - Add informational message about auto-formatted changes

Ansonhkg had a problem deploying to Health Check August 13, 2025 15:29 — with GitHub Actions Failure

Ansonhkg had a problem deploying to Health Check August 13, 2025 15:43 — with GitHub Actions Failure

FedericoAmura reviewed Aug 13, 2025

View reviewed changes

fix(prettier): update .prettierignore to maintain dist folder exclusion

6b44df7

#860 (comment)

Ansonhkg temporarily deployed to Health Check August 13, 2025 15:51 — with GitHub Actions Inactive

feat(constants): add DEV_PRIVATE_KEY constant and refactor usage in L…

7cedd96

…itClient and chain manager files

Ansonhkg temporarily deployed to Health Check August 13, 2025 16:06 — with GitHub Actions Inactive

Ansonhkg requested a review from FedericoAmura August 13, 2025 16:07

chore(PR): init

bcf6c21

Ansonhkg temporarily deployed to Health Check August 13, 2025 16:33 — with GitHub Actions Inactive

This comment was marked as outdated.

Sign in to view

Ansonhkg requested a review from Copilot August 13, 2025 18:05

Copilot AI reviewed Aug 13, 2025

View reviewed changes

Ansonhkg merged commit 61fe370 into naga Aug 14, 2025
3 checks passed

Ansonhkg deleted the feature/jss-34-naga-fix-getting-node-prices-for-session-sigs branch August 14, 2025 18:30

	// Use read-only account for viewing PKPs
	// Use read-only account for fetching node prices

		@@ -1428,3 +1428,6 @@ export const SIWE_URI_PREFIX = {

		export type SIWE_URI_PREFIX_TYPE = ConstantKeys<typeof SIWE_URI_PREFIX>;
		export type SIWE_URI_PREFIX_VALUES = ConstantValues<typeof SIWE_URI_PREFIX>;

+/**
+ * Standard Anvil/Hardhat development private key.
+ * This key is used for local development and testing only.
+ * It is publicly known and should never be used in production environments.
+ */

[Fix] get fresh node prices for paid endpoint calls #860

[Fix] get fresh node prices for paid endpoint calls #860

Uh oh!

Conversation

Ansonhkg commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHAT

Behavioural Tests

Test 1 - Make two concurrent calls to trigger "Local promise is already fetching"

Test 2 - Testing stale cache by first execute within the cache window (3 seconds) and one beyond cache window of 3 seconds

Uh oh!

Uh oh!

Uh oh!

FedericoAmura Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Ansonhkg Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DashKash54 Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Ansonhkg Aug 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FedericoAmura Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Ansonhkg Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Ansonhkg commented Aug 14, 2025

Uh oh!

Uh oh!

Uh oh!

Ansonhkg commented Aug 13, 2025 •

edited

Loading

Ansonhkg Aug 13, 2025 •

edited

Loading