refactor(accs): renamed .raw() function and added several new APIs #869
+188
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
unifiedAccessControlConditions
requires aconditionType
discriminator, but the Accs Builder's.raw()
function returns “as-is” (no discriminator was added), and because the discriminator is only used for routing, it wasn't able to route to the correct code path to canonicalise the accs conditions.That says, when passing unified accs, you must specify
conditionType
to be eitherevmBasic
,evmContract
,solRpc
orcosmos
.The confusion occurred due to the the function
.raw()
name is misleading, it's not truly raw since it gets canonicalised and validated internally.Changes
raw()
->.unifiedAccs()
.evmBasic()
function.evmContract()
function.solRpc()
function.cosmos()
functionTest
Use the result from
.evmBasic
to encrypt, then use the result from.unifiedAccs
to decrypt. Both should produce the same accs so it should work interchangeably.NETWORK=naga-dev bun test ./e2e/src/v7-compatability.spec.ts