Add grouped W&B metric logging with per-correctness/category breakdowns#1
Open
matthewyryang wants to merge 2 commits intoLLM360:mainfrom
Open
Add grouped W&B metric logging with per-correctness/category breakdowns#1matthewyryang wants to merge 2 commits intoLLM360:mainfrom
matthewyryang wants to merge 2 commits intoLLM360:mainfrom
Conversation
matthewyryang
commented
Apr 10, 2026
matthewyryang
commented
- New top-level W&B sections: policy_shift/, train_inference_mismatch/, optimization/, reward/, response_stats/ — additive to existing train/ and rollout/ keys
- Add log_probs, old_log_probs, train_rollout_logprob_diff (signed), ref_kl metrics to reported_loss in policy_loss_function
- Emit grouped duplicates in log_train_step and log_rollout_data
- rollout.py: per-correctness (correct/incorrect) and per-category splits of reward and response_stats metrics; all_correct/incorrect_group_frac for GRPO; auto-detects category from sample.metadata or args.log_problem_category
- New top-level W&B sections: policy_shift/, train_inference_mismatch/, optimization/, reward/, response_stats/ — additive to existing train/ and rollout/ keys - Add log_probs, old_log_probs, train_rollout_logprob_diff (signed), ref_kl metrics to reported_loss in policy_loss_function - Emit grouped duplicates in log_train_step and log_rollout_data - rollout.py: per-correctness (correct/incorrect) and per-category splits of reward and response_stats metrics; all_correct/incorrect_group_frac for GRPO; auto-detects category from sample.metadata or args.log_problem_category Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.