Local version of #908 #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oalesced pool size The non-actual high water mark does not include the overallocated size when rounding user allocations up to the alignment. This means that the non-actual high water mark may be too small when repeatedly allocating and deallocating the same sizes in a pool, leading to unnecessary reallocation of the backing buffers.
…nd DynamicPoolList
…ned highwater mark
kab163
reviewed
Oct 8, 2024
Comment on lines
42
to
45
| // Total size allocated (bytes) | ||
| std::size_t m_aligned_bytes{0}; | ||
| std::size_t m_aligned_highwatermark{0}; | ||
| std::size_t m_actual_bytes{0}; |
There was a problem hiding this comment.
Suggested change
| // Total size allocated (bytes) | |
| std::size_t m_aligned_bytes{0}; | |
| std::size_t m_aligned_highwatermark{0}; | |
| std::size_t m_actual_bytes{0}; | |
| std::size_t m_aligned_bytes{0}; // Current size of pool, rounded up to alignment (bytes) | |
| std::size_t m_aligned_highwatermark{0}; // Highwatermark of the aligned size (bytes) | |
| std::size_t m_actual_bytes{0}; // Total size allocated (bytes) |
| std::size_t m_actual_bytes{0}; | ||
| std::size_t m_current_size{0}; | ||
| std::size_t m_actual_highwatermark{0}; |
There was a problem hiding this comment.
Suggested change
| std::size_t m_actual_highwatermark{0}; | |
| std::size_t m_actual_highwatermark{0}; // Highwatermark of the actual size (bytes) |
Comment on lines
79
to
+81
| std::size_t getActualHighwaterMark() const noexcept; | ||
| std::size_t getAlignedSize() const noexcept; | ||
| std::size_t getAlignedHighwaterMark() const noexcept; |
There was a problem hiding this comment.
Suggested change
| std::size_t getActualHighwaterMark() const noexcept; | |
| std::size_t getAlignedSize() const noexcept; | |
| std::size_t getAlignedHighwaterMark() const noexcept; | |
| /* | |
| * \brief Returns the Highwatermark of the total size allocated in bytes. | |
| */ | |
| std::size_t getActualHighwaterMark() const noexcept; | |
| /* | |
| * \brief Returns the current size of pool, rounded up to alignment in bytes. | |
| */ | |
| std::size_t getAlignedSize() const noexcept; | |
| /* | |
| * \brief Returns the Highwatermark of the aligned size in bytes. | |
| */ | |
| std::size_t getAlignedHighwaterMark() const noexcept; |
| @@ -76,8 +76,9 @@ class DynamicPoolList : public AllocationStrategy { | |||
| std::size_t getTotalBlocks() const noexcept; | |||
|
|
|||
| std::size_t getActualSize() const noexcept override; | |||
There was a problem hiding this comment.
Suggested change
| std::size_t getActualSize() const noexcept override; | |
| /* | |
| * \brief Returns the total size allocated in bytes. | |
| */ | |
| std::size_t getActualSize() const noexcept override; |
Comment on lines
165
to
169
| std::size_t m_total_blocks{0}; | ||
| std::size_t m_releasable_blocks{0}; | ||
| std::size_t m_aligned_bytes{0}; | ||
| std::size_t m_aligned_highwatermark{0}; | ||
| std::size_t m_actual_bytes{0}; |
There was a problem hiding this comment.
Suggested change
| std::size_t m_total_blocks{0}; | |
| std::size_t m_releasable_blocks{0}; | |
| std::size_t m_aligned_bytes{0}; | |
| std::size_t m_aligned_highwatermark{0}; | |
| std::size_t m_actual_bytes{0}; | |
| std::size_t m_total_blocks{0}; | |
| std::size_t m_releasable_blocks{0}; | |
| std::size_t m_aligned_bytes{0}; // Current size of the pool, rounded up to alignment | |
| std::size_t m_aligned_highwatermark{0}; // Highwatermark of the aligned size | |
| std::size_t m_actual_bytes{0}; // Total size allocated in bytes |
| std::size_t m_actual_bytes{0}; | ||
| std::size_t m_current_bytes{0}; | ||
| std::size_t m_releasable_bytes{0}; | ||
| std::size_t m_actual_highwatermark{0}; |
There was a problem hiding this comment.
Suggested change
| std::size_t m_actual_highwatermark{0}; | |
| std::size_t m_actual_highwatermark{0}; // Highwatermark of the actual size |
davidbeckingsale
force-pushed
the
pr-from-fork/908
branch
from
d87e3d0 to
ebf769b
Compare
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.