Skip to content

Conversation

@gunney1
Copy link
Contributor

@gunney1 gunney1 commented Sep 29, 2025

Summary

  • This PR is a bug fix
  • It deletes a few lines of code that removed Groups post-copy if they have no Views under them.

The deletion is unexpected and breaking some mint code that requires empty Groups in the destination hierarchy.

Fixes #1674

Not sure why similar hierarchy copies remove View-less Groups,
but the behavior is unexpected and breaking some mint code that
requires empty Groups in the destination hierarchy.
@gunney1 gunney1 self-assigned this Sep 29, 2025
@gunney1 gunney1 added bug Something isn't working Sidre Issues related to Axom's 'sidre' component labels Sep 29, 2025
@gunney1 gunney1 marked this pull request as ready for review September 30, 2025 16:52
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gunney1

@gunney1 gunney1 merged commit 328550d into develop Oct 2, 2025
15 checks passed
@gunney1 gunney1 deleted the bug/gunney/keep-copied-empty-groups branch October 2, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Sidre Issues related to Axom's 'sidre' component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group::deepCopyToConduit drops View-less groups

6 participants