Feature/gunney/extend klee geometries (second try) #1679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cone provides interface for specify a cone geometry. Type-free geometry is work-in-progress toward allowing klee::Geometry to support arbitrary geometry types without requiring a primal representation of that geometry. Also add asterisks to comment blocks.
…ries' into feature/gunney/extend-klee-geometry
…ies' into feature/gunney/extend-klee-geometry
Feature/gunney/extend klee geometry
kennyweiss
approved these changes
Oct 1, 2025
gunney1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a redo of #1666, which was approved by @kennyweiss, @Arlie-Capps and @bmhan12. Please re-approve. I screwed up the merge step somehow and it didn't merge into
develop. The description below is exactly the same.conduit::Nodefor internally storing geomety data and allow for new geometry formats and information without further changes to the code. Currently, this information is stored in a variety of objects:Tetrahedron,Hexahedron,Sphere, etc.)sidre::Groupand topology name (for geometries stored in blueprint mesh convention)Problems with using primitives in
GeometryGeometryhas to keep supplemental data).Geometryto support new shapes.For these reasons, primitives will be removed in favor of the hierarchy representation.
Geometryis supporting both during the transition.This is a WIP. It is being used in the on-going work to re-factor and improve clipping performance and may still change to support that goal.
Dependencies
The mesh clipping refactor includes multiple PRs. Please review these before this one.