Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved log output for NLP scaling #709

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

improved log output for NLP scaling #709

wants to merge 2 commits into from

Conversation

cnpetra
Copy link
Collaborator

@cnpetra cnpetra commented Feb 12, 2025 •
edited
Loading

Logs (for verbosity>=4) info on the internal NLP scaling such as which scaling method and some scaling scalars.

@cnpetra cnpetra marked this pull request as draft February 12, 2025 22:10
@cnpetra cnpetra requested a review from nychiang February 12, 2025 22:56
@cnpetra cnpetra marked this pull request as ready for review February 12, 2025 22:56
nychiang
nychiang approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@nychiang nychiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about what brings you here to modify this log output. :-)

@cnpetra
Copy link
Collaborator Author

cnpetra commented Feb 13, 2025

Just curious about what brings you here to modify this log output. :-)

ill-scaled problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nychiang nychiang nychiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnpetra @nychiang