Conversation
Contributor
审阅者指南（在小型 PR 上折叠显示）审阅者指南将项目版本更新为 7.12.8，并在群成员信息 action 中略微调整日志记录，同时包含相关文档/包元数据的变更。 按文件分类的变更
小贴士与指令与 Sourcery 交互
自定义你的体验访问你的 控制面板 以：
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the project version to 7.12.8 and slightly adjusts logging in the group member info action while including associated doc/package metadata changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - 我发现了 1 个问题，并给出了一些整体性的反馈：
- 将整个
info对象记录到日志中，而不是只记录info.simpleInfo.baseInfo，可能会显著增加日志量，并暴露比预期更多的敏感字段；如果这只是用于调试，建议缩小日志中字段的范围。
给 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- Logging the entire `info` object instead of `info.simpleInfo.baseInfo` may significantly increase log volume and expose more sensitive fields than intended; consider narrowing the logged fields if this was only for debugging.
## Individual Comments
### Comment 1
<location path="src/onebot11/action/group/GetGroupMemberInfo.ts" line_range="41" />
<code_context>
}
if (info) {
- this.ctx.logger.info(info.simpleInfo.baseInfo)
+ this.ctx.logger.info(info)
ret.sex = OB11Entities.sex(info.simpleInfo.baseInfo.sex)
ret.qq_level = info.commonExt?.qqLevel && calcQQLevel(info.commonExt.qqLevel) || 0
</code_context>
<issue_to_address>
**🚨 suggestion (security):** Logging the full `info` object may be noisy and could include unnecessary or sensitive data; consider narrowing or changing the log level.
This change logs the entire `info` object instead of `info.simpleInfo.baseInfo`, which may increase log volume and expose additional fields (including possible identifiers/PII). Consider logging only the required subset or lowering this to debug/trace if the full object is needed for diagnostics.
</issue_to_address>帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈来改进后续的 Review。
Original comment in English
Hey - I've found 1 issue, and left some high level feedback:
- Logging the entire
infoobject instead ofinfo.simpleInfo.baseInfomay significantly increase log volume and expose more sensitive fields than intended; consider narrowing the logged fields if this was only for debugging.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Logging the entire `info` object instead of `info.simpleInfo.baseInfo` may significantly increase log volume and expose more sensitive fields than intended; consider narrowing the logged fields if this was only for debugging.
## Individual Comments
### Comment 1
<location path="src/onebot11/action/group/GetGroupMemberInfo.ts" line_range="41" />
<code_context>
}
if (info) {
- this.ctx.logger.info(info.simpleInfo.baseInfo)
+ this.ctx.logger.info(info)
ret.sex = OB11Entities.sex(info.simpleInfo.baseInfo.sex)
ret.qq_level = info.commonExt?.qqLevel && calcQQLevel(info.commonExt.qqLevel) || 0
</code_context>
<issue_to_address>
**🚨 suggestion (security):** Logging the full `info` object may be noisy and could include unnecessary or sensitive data; consider narrowing or changing the log level.
This change logs the entire `info` object instead of `info.simpleInfo.baseInfo`, which may increase log volume and expose additional fields (including possible identifiers/PII). Consider logging only the required subset or lowering this to debug/trace if the full object is needed for diagnostics.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| } | ||
| if (info) { | ||
| this.ctx.logger.info(info.simpleInfo.baseInfo) | ||
| this.ctx.logger.info(info) |
Contributor
There was a problem hiding this comment.
🚨 suggestion (security): 将完整的 info 对象记录到日志中可能会产生大量噪声，并包含不必要或敏感的数据；建议缩小日志内容范围或调整日志级别。
这一改动会记录整个 info 对象，而不是 info.simpleInfo.baseInfo，这可能会增加日志体积并暴露额外字段（包括可能的标识符/个人隐私信息）。如果确实需要完整对象用于诊断，建议只记录必要的子集，或者将日志级别降为 debug/trace。
Original comment in English
🚨 suggestion (security): Logging the full info object may be noisy and could include unnecessary or sensitive data; consider narrowing or changing the log level.
This change logs the entire info object instead of info.simpleInfo.baseInfo, which may increase log volume and expose additional fields (including possible identifiers/PII). Consider logging only the required subset or lowering this to debug/trace if the full object is needed for diagnostics.
Test Report
✅ All tests passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
更新群组成员信息的日志记录方式，并提升项目版本。
Enhancements:
baseInfo部分。Chores:
Original summary in English
Summary by Sourcery
Update logging of group member info and bump project version.
Enhancements:
Chores: