This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix that lnd might not be detected on Mac OS due to misaligned ps output#124
Closed
Empact wants to merge 1 commit into
Closed
Fix that lnd might not be detected on Mac OS due to misaligned ps output#124Empact wants to merge 1 commit into
ps output#124Empact wants to merge 1 commit into
Conversation
Empact
force-pushed
the
fix/lnd-detection
branch
from
ca0911d to
cbb1d83
Compare
Contributor
Author
|
Updated to include specific output columns. This is tested to work on my machine. Opened something against ps-node as well. neekey/ps#69 |
Empact
changed the title
ps x -o pid,command rather than ps lx
Empact
force-pushed
the
fix/lnd-detection
branch
3 times, most recently
from
f75238c to
baafcb8
Compare
Empact
changed the title
ps x -o pid,command rather than ps lxps output
Member
|
@Empact we should test this on other machines just in case, or wait to see how neekey/ps#69 gets handled |
Empact
force-pushed
the
fix/lnd-detection
branch
2 times, most recently
from
d7d4a11 to
833b71d
Compare
Empact
force-pushed
the
fix/lnd-detection
branch
from
833b71d to
cd6c1b8
Compare
Empact
force-pushed
the
fix/lnd-detection
branch
from
cd6c1b8 to
d21401e
Compare
Empact
force-pushed
the
fix/lnd-detection
branch
from
d21401e to
ad3f257
Compare
Empact
force-pushed
the
fix/lnd-detection
branch
from
2184f87 to
0f6621e
Compare
`ps x -o pid,command` rather than `ps lx`
The default ps-node lookup is via ps lx, which includes:
-l Display information associated with the following keywords:
uid, pid, ppid, flags, cpu, pri, nice, vsz=SZ, rss, wchan,
state=S, paddr=ADDR, tty, time, and command=CMD.
On mac, the `ps l` output can be misaligned, e.g. when some VSZ field is
longer than expected.
Many of these fields are unnecessary because we're looking up by name only,
so we can lookup using only the command fields of ps.
https://gist.github.com/ivankovacevic/9918272
More on the issue with ps-node:
neekey/table-parser#11
neekey/ps#64
Empact
force-pushed
the
fix/lnd-detection
branch
from
0f6621e to
90236da
Compare
Contributor
Author
|
Rebased, this is still an issue fyi. Will ping neekey again. |
Pull Request Test Coverage Report for Build 3735
💛 - Coveralls |
Member
|
We no longer attempt to detect wether or not lnd is already running on the user's machine as there is no longer a hard requirement that our internal instance of lnd must be the only one running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mac, the ps output can be misaligned which prevents lnd from being detected, e.g. when some VSZ field is longer than expected.
The default ps-node lookup is via ps lx, which includes:
Here's some example misaligned output from
ps lxMany of these fields are unnecessary because we're looking up by name only,
so we can lookup using only the
-o pid,commandoutput.neekey/table-parser#11
neekey/ps#64