Skip to content

Improving facet-subtraction workflow#121

Open
jurjen93 wants to merge 3 commits intomasterfrom
upd_facet_subtr
Open

Improving facet-subtraction workflow#121
jurjen93 wants to merge 3 commits intomasterfrom
upd_facet_subtr

Conversation

@jurjen93
Copy link
Copy Markdown
Member

@jurjen93 jurjen93 commented Apr 27, 2026

  • Increased polygon boundary to have small overlaps between facets.
  • Update DP3 command for applying solutions

@jurjen93 jurjen93 requested a review from tikk3r April 27, 2026 07:07
@jurjen93 jurjen93 changed the title Enlarge polygon boundaries Improving facet-subtraction workflow Apr 28, 2026
Comment thread scripts/make_facet_ms.py
f'ac{ac_count}.parmdb={applycal_h5}',
f'ac{ac_count}.correction={corr}']
f'ac{ac_count}.correction={corr}',
f'ac{ac_count}.missingantennabehavior=flag']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A clarifying question: what drives the choice for this parameter? Since the delay solutions are pre-applied for the DD calibration one way or another, I would not expect a mismatch in stations at this point. Are there cases were stations are removed from the solutions during the DD calibration?

Copy link
Copy Markdown
Member Author

@jurjen93 jurjen93 May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I had a case where flagged stations were removed.

So, instead of ending up in an error, and having to add these back yourself manually, its easier to flag these during the applycal

Copy link
Copy Markdown
Member

@tikk3r tikk3r May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any other use of missingantennabehavior in the pipeline at the moment. Doesn't this imply that all stations behaved ok during the delay calibration and that this is strange? I wonder in that case whether this is overlooked earlier in the pipeline, or what would cause the DD solutions to fail so catastrophically that stations needed removing in that case.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it comes from: https://github.com/LOFAR-VLBI/pilot/blob/master/steps/make_concat_parsets.cwl#L46
This option removes fully flagged stations from the MS. This is a handy feature because it saves some storage space for large datasets.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be earlier done in the pipeline though (not only during dd-calibration and the facet subtraction), because it indeed comes from flagging earlier in the pipeline.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my specific case I dont have access to the delay calibration solution plots or the solutions themselves to see what happened (those were generated by James and I dont find them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants