Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip install wheel to main.yml #335

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

OliviaLynn
Copy link
Member

@OliviaLynn OliviaLynn commented Apr 19, 2023

Fixes #333; lets RAIL run on github actions again.

Based on the pypa/pip#8559 deprecation thread.

Talked to someone at somoclu and this seemed the best course of action.

(Note, this adds to the explicit pip install numpy line we've already needed before installing somoclu: peterwittek/somoclu#165).

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (962159b) 100.00% compared to head (278b90d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #335   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2502      2502           
=========================================
  Hits          2502      2502           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@OliviaLynn OliviaLynn marked this pull request as ready for review April 19, 2023 14:07
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@OliviaLynn OliviaLynn merged commit 82da866 into main Apr 19, 2023
@OliviaLynn OliviaLynn deleted the issue/333/wheels-and-pip-231 branch April 19, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main.yml fails to build wheel when somoclu is a dependency
2 participants