Skip to content

fix(viewer): main is red — the frame test pinned the pre-#3039 side normal #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louistrue merged 1 commit into from
Aug 22, 2026
Merged

fix(viewer): main is red — the frame test pinned the pre-#3039 side normal #3105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions apps/viewer/src/store/slices/addElementMeshes.frame.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,23 @@ describe('addElementMeshes: IFC storey-local to renderer frame (#2802)', () => {

// The bottom face is [0, 0, -1] in IFC, so its x and y are BOTH zero and
// it cannot see the `-face.normal[1]` term at all: flip that sign and the
// assertions above still pass. Vertices 8..11 are the first side face,
// IFC normal [0, 1, 0], which maps to renderer [0, 0, -1] and is the
// component that discriminates.
// assertions above still pass. Vertices 8..11 are the first side face, so
// that is the component which discriminates.
//
// That face is corners [0, 4, 5, 1], all four of which sit at y = -Depth/2,
// so it is the -Y face of the box and its OUTWARD IFC normal is [0, -1, 0],
// mapping to renderer [0, 0, +1].
//
// This assertion previously read `-1`, pinning [0, +1, 0] — the INWARD
// direction. It passed because the side normals were inward at the time,
// which is the defect #3039 fixed by orienting each face away from the box
// centre. So the expectation was pinned to behaviour that was wrong, and
// #3058 and #3039 were each green alone and red together. Computed rather
// than re-derived by eye: box centre (0, 0, 1.5), face centre (0, -1, 1.5),
// difference (0, -1, 0).
near(n[24], 0, 'side normal x');
near(n[25], 0, 'side normal y');
near(n[26], -1, 'side normal z (IFC +Y becomes renderer -Z)');
near(n[26], 1, 'side normal z (IFC -Y becomes renderer +Z)');

// Every normal is unit length, so none was left un-normalised by the swap.
// Note this alone cannot see a sign flip, which is why the component
Expand Down
Loading