Skip to content

tag cropmarks as artifact, tagging issue 1064 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
u-fischer wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tag cropmarks as artifact, tagging issue 1064 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bb3e56
tag cropmarks as artifact, tagging issue 1064
u-fischer Nov 15, 2025
d2c958a
test for tagging code ...
u-fischer Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion build.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,9 @@ module = "geometry"

unpackfiles = {'geometry.dtx'}

textfiles = {"README.md","changes.txt"}
textfiles = {"README.md","changes.txt"}

checkruns=2

checkengines={"luatex"}
stdengine="luatex"
4 changes: 4 additions & 0 deletions changes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2025-11-16
* tag cropmarks are artifacts, see https://github.com/latex3/tagging-project/issues/1064


2020-01-02 Release 5.9
* Include German translation (previously distributed as geometry-de on ctan)
* Use iftex versions of \ifxetex, \ifpdf
Expand Down
26 changes: 19 additions & 7 deletions geometry.dtx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3395,13 +3395,25 @@ the derived files: geometry.{sty,ins,drv}, geometry-samples.tex.
%
% Macros for the page frames and cropmarks.
% \begin{macrocode}
\def\Gm@cropmark(#1,#2,#3,#4){%
\begin{picture}(0,0)
\setlength\unitlength{1truemm}%
\linethickness{0.25pt}%
\put(#3,0){\line(#1,0){17}}%
\put(0,#4){\line(0,#2){17}}%
\end{picture}}%
\IfDocumentMetadataTF
Copy link
Member

@davidcarlisle davidcarlisle Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed but it probably shouldn't be, shouldn't we make picture always have a no-op argument as we have done for the equivalent keys on \includegraphics ? (not a question for this PR)

Copy link
Author

@u-fischer u-fischer Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should do that (actually I nearly forgot the test because I thought we had already ;-))

{
\def\Gm@cropmark(#1,#2,#3,#4){%
\begin{picture}[artifact](0,0)
\setlength\unitlength{1truemm}%
\linethickness{0.25pt}%
\put(#3,0){\line(#1,0){17}}%
\put(0,#4){\line(0,#2){17}}%
\end{picture}}%
}
{
\def\Gm@cropmark(#1,#2,#3,#4){%
\begin{picture}(0,0)
\setlength\unitlength{1truemm}%
\linethickness{0.25pt}%
\put(#3,0){\line(#1,0){17}}%
\put(0,#4){\line(0,#2){17}}%
\end{picture}}%
}
\providecommand*\vb@xt@{\vbox to}%
\def\Gm@vrule{\vrule width 0.2pt height\textheight depth\z@}%
\def\Gm@hrule{\hrule height 0.2pt depth\z@ width\textwidth}%
Expand Down
10 changes: 10 additions & 0 deletions testfiles/tagging1064-2.lvt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
\input{regression-test}
\documentclass{article}
\usepackage[layoutsize={8in,8in},showcrop]{geometry}

\title{geometry tagging test}
\begin{document}
\START
some text

\end{document}
4 changes: 4 additions & 0 deletions testfiles/tagging1064-2.tlg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
This is a generated file for the l3build validation system.
Don't change this file in any respect.
[1
] (tagging1064-2.aux)
11 changes: 11 additions & 0 deletions testfiles/tagging1064.lvt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
\DocumentMetadata{tagging=on}
\input{regression-test}
\documentclass{article}
\usepackage[layoutsize={8in,8in},showcrop]{geometry}

\title{geometry tagging test}
\begin{document}
\START
some text

\end{document}
15 changes: 15 additions & 0 deletions testfiles/tagging1064.tlg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
This is a generated file for the l3build validation system.
Don't change this file in any respect.
[1
]<<latex-list-css.html>><<latex-align-css.html>> (tagging1064.aux)
Package tagpdf Info: Finalizing the tagging structure:
(tagpdf) Writing out ~6 structure objects
(tagpdf) with ~7 'MC' leaf nodes.
(tagpdf) Be patient if there are lots of objects!
Package tagpdf Info: writing ParentTree
Package tagpdf Info: writing IDTree
Package tagpdf Info: writing RoleMap
Package tagpdf Info: writing ClassMap
Package tagpdf Info: writing NameSpaces
Package tagpdf Info: writing StructElems
Package tagpdf Info: writing Root