LibWeb/Layout: Add support for overflow-wrap property #3965
+143
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrankamal
commented
Mar 16, 2025
Comment on lines
562
to
592
| // FIXME: | ||
| { | ||
| auto glyph_run = Gfx::shape_text({ x, 0 }, letter_spacing.to_float(), chunk.view, chunk.font, text_type, shape_features); | ||
| dbgln("Shaping current chunk: {}", chunk.view); | ||
|
|
||
| CSSPixels chunk_width = CSSPixels::nearest_value_for(glyph_run->width()); | ||
| if (text_node.computed_values().overflow_wrap() == CSS::OverflowWrap::BreakWord) { | ||
| // while glyph_run.width > context->available_space() | ||
| // reshape text with lesser chars | ||
| // reset the text_node iterator back to characters removed from initial text_shape | ||
| auto maybe_available_space = m_inline_formatting_context.available_space(); | ||
| if (maybe_available_space.has_value()) { | ||
| auto available_space = maybe_available_space.value(); | ||
| auto removed_code_points_count = 0; | ||
| auto new_chunk_view = chunk.view; | ||
| dbgln("Chunk Width: {}, Available Width: {}", chunk_width.to_int(), available_space.width.to_px_or_zero().to_int()); | ||
|
|
||
| // FIXME: Use binary search to find the number of characters to rewind to | ||
| while (chunk_width + CSSPixels::from_raw(removed_code_points_count) > available_space.width.to_px_or_zero()) { | ||
| new_chunk_view = new_chunk_view.unicode_substring_view(0, new_chunk_view.length() - 1); | ||
| glyph_run = Gfx::shape_text({ x, 0 }, letter_spacing.to_float(), new_chunk_view, chunk.font, text_type, shape_features); | ||
| dbgln("Shaped current chunk: {}", new_chunk_view); | ||
| chunk_width = CSSPixels::nearest_value_for(glyph_run->width()); | ||
| removed_code_points_count++; | ||
| } | ||
|
|
||
| // FIXME: Rewind the chunk_iterator back removed_code_points_count times. | ||
|
|
||
| dbgln("Removed {} codepoints when Breaking Words", removed_code_points_count); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Probably a better implementation is possible
mehrankamal
force-pushed
the
overflow-wrap-impl
branch
from
80ac213 to
cdd1218
Compare
teaalltr
reviewed
Mar 16, 2025
| name="assert" | ||
| content="The 'overflow-wrap' property set 'break-word' breaks the word at an arbitrary point" | ||
| /> | ||
| <link rel="stylesheet" type="text/css" href="../../..../../../fonts/ahem.css" /> |
There was a problem hiding this comment.
Here there should be a typo, "/..../", too many dots I guess
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
github-actions
bot
added
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://www.w3.org/TR/css-text-3/#overflow-wrap-property
This PR adds support for
overflow-wrapand it's legacyword-wrapproperty