LibWeb: Change dump_selector function in dump.cpp #4012
+120
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
Asaadziad
force-pushed
the
libweb-dump-fix-me
branch
3 times, most recently
from
08420b3 to
c760a0f
Compare
Asaadziad
changed the title
This change updates the dump_selector function in order to resolve the FIXME.
Asaadziad
force-pushed
the
libweb-dump-fix-me
branch
from
c760a0f to
1603d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to resolve the FIXME
Add an enum NameType to the SimpleSelector struct in order to be able to tell which selector has a name or qualified name or none. Change the type dump to a switch case, and add 2 functions to handle PseudoClass and Attribute because they were too long