LibWeb: Update Element::directionality() for bdi elements to match spec #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmta
approved these changes
Mar 21, 2025
|
Welcome to the project, thank you for implementing this! |
|
@Noah55-maker the |
Noah55-maker
force-pushed
the
bdi-directionality
branch
from
d34ad8e to
bac756c
Compare
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
This fixes three WPT test cases at html/dom/elements/global-attributes/dir-assorted.window.html Update test expectations for Tests/LibWeb/Text/expected/wpt-import/css/selectors/dir-pseudo-on-bdi-element.txt
Noah55-maker
force-pushed
the
bdi-directionality
branch
from
bac756c to
5f7d915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three WPT test cases at html/dom/elements/global-attributes/dir-assorted.window.html