LibWeb: Don't import raw X25519 key of incorrect length #5582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trflynn89
reviewed
Jul 23, 2025
awesomekling
requested changes
Jul 23, 2025
hopafoot
force-pushed
the
fix/x25519-bad-length-raw-import
branch
from
023c6a4 to
e8b0fa8
Compare
hopafoot
force-pushed
the
fix/x25519-bad-length-raw-import
branch
from
e8b0fa8 to
c8c506a
Compare
ADKaster
approved these changes
Jul 25, 2025
|
Well I say that. but can you rebaseline/update the failing test?
|
|
@ADKaster, done. I think I need approval to rerun CI, though. Sorry for missing this before, this is my first contribution to this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets 4 more WPT subtests related to rejecting imports of bad X25519 keys in raw format.
wpt tests