LibWeb: Add gap-rule-overlap CSS property (fixes WPT parsing) #7003
Conversation
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
r-b-1
force-pushed
the
libweb/add-gap-rule-overlap
branch
5 times, most recently
from
457fc1a to
837652b
Compare
| "color-svg", | ||
| "column", | ||
| "column-reverse", | ||
| "column-over-row", |
There was a problem hiding this comment.
Please add these keywords in the same commit you add the property, otherwise that first commit won't compile.
There was a problem hiding this comment.
Okay! They are now in the same commit, thank you!
| @@ -0,0 +1,7 @@ | |||
| Harness status: OK | |||
There was a problem hiding this comment.
You've committed the test output but not the actual test, please add that in. 😅
There was a problem hiding this comment.
Okay, the actual test is now included!
- animation-type: discrete - inherited: false - initial: row-over-column - valid-identifiers: [row-over- column, column-over-row] Passes WPT: https://wpt.live/css/css-gaps/parsing/rule-overlap-valid.html LibWeb: Add row-over-column and column-over-row CSS keywords Enables Keyword.h enums (RowOverColumn, ColumnOverRow) for PropertyID.cpp.
Verifies gap-rule-overlap parsing passes (2/2)
r-b-1
force-pushed
the
libweb/add-gap-rule-overlap
branch
from
837652b to
160d2b7
Compare
3 participants
Adds support for the non-standard
gap-rule-overlapCSS property (from CSS Gap Decorations draft) to pass the external WPT parsing test:https://wpt.live/css/css-gaps/parsing/rule-overlap-valid.html
Changes:
Libraries/LibWeb/CSS/Properties.json:animation-type: discreteinherited: falseinitial: row-over-columnvalid-identifiers: [\"row-over-column\", \"column-over-row\"]Libraries/LibWeb/CSS/Keywords.json: Addedrow-over-column,column-over-row(alphabetical)Tests/LibWeb/Text/{input,expected}/wpt-import/css/css-gaps/parsing/rule-overlap-valid.*(2/2 PASS)Testing:
./Meta/ladybird.py rebuild LibWeb→ Clean (PropertyID.cpp compiles, Keyword.h enums generated)./Meta/ladybird.py run test-web -f Text/input/wpt-import/css/css-gaps/parsing/rule-overlap-valid.html→ PASS (2/2)./Meta/lint-ci.sh→ Clean (minor tool skips OK)No breaking changes. Small/atomic first contrib.
./Meta/lint-ci.shpassed (relevant checks)