LibWeb: dont inject natural sizes from prepare_for_replaced_layout

[jonbgamble]

Instead, compute them in accessors.

Add TextAreaBox and TextInputBox to Layout so that textarea and text inputs can be stretched when auto.

Fix #634, fix #6040, fix #7070, and possibly related issues involving baseline, cross axis sizing, aspect ratio, canvas, size containment, and textarea

[ladybird-bot]

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

[github-actions]

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

[Gingeh]

I can't comment on the implementation itself, but this patch fixes the page I opened #6040 for

[gmta]

Hi! Please check our contribution guidelines, and particularly:

Split your changes into separate, atomic commits (i.e. A commit per feature or fix, where the build, tests and the system are all functioning).

Basically, whenever your commit message starts to describe more than one thing, it's very likely that we'd like to see separate commits. You should split them up to discern between non-functional changes involving code cleanup, refactors to prepare for changes, bugfixes and functional changes.

[jonbgamble]

I will say this about your commit message linter - I have had more enjoyable interactions with the rust borrow checker.

[gmta]

@jonbgamble

I will say this about your commit message linter - I have had more enjoyable interactions with the rust borrow checker.

Did you use pre-commit locally to lint your commits before pushing?

If there's anything in particular that we should improve with the commit linter, feel free to raise an issue or submit a PR.

[jonbgamble]

Did you use pre-commit locally to lint your commits before pushing?

I did not, and thanks for the heads up about it. I am just now remembering to run lint-clang-format.py

If there's anything in particular that we should improve with the commit linter, feel free to raise an issue or submit a PR.

Oh, it was just frustration from trying to force push a bunch of pseudo-historical commits carefully constructed from manual edits of git add -p hunks, only to be told "such and such commit message first line ends with a period" or "commit message isn't capital after the colon".

I'm miles away from an actionable suggestion.

[jonbgamble]

I wonder if it makes sense to require Category in the PR only. The commits themselves are ostensibly be related to this owning Category, and if they diverge then the true scope of each is readily available from the paths of their changed files. It could claw back 8-12 precious characters per commit for more context that may be less redundant.

But maybe there is automated reporting going on where commit titles are readily available and files are not. I did notice the contributing.md mentions joining categories with + which sounds rather reporty.