Add Archive of our own Provider

[PrecociouslyDigital]

No description provided.

[LagradOst]

Bit unsure if unfinished as not everything is used here, it seams to work at least

[PrecociouslyDigital]

It's done and ready for merge on my end!

[LagradOst]

dont do too much UI as all UI is currently being refacored

[PrecociouslyDigital]

dont do too much UI as all UI is currently being refacored

What part of the UI are you referring to? the login system?

[LagradOst]

dont do too much UI as all UI is currently being refacored

What part of the UI are you referring to? the login system?

yup

[PrecociouslyDigital]

Unfortunately it needs some UI so the user can enter their username and password to access protected works on AO3; The total extent of this is just a setting in the settings menu.

[LagradOst]

Unfortunately it needs some UI so the user can enter their username and password to access protected works on AO3; The total extent of this is just a setting in the settings menu.

yes, just dont add anything extra

[PrecociouslyDigital]

It's ready for review/merge now

[LagradOst]

An app wide cookie jar makes everything harder to debug and handle. Easier for us to be explicit with cookies for deterministic behavior.

If you want sessions with cookies I think https://github.com/Blatzar/NiceHttp/blob/master/library/src/main/java/com/lagradost/nicehttp/Session.kt would work good enough for limited time cookies.

At the very least please create your own cookie requests instance instead of an app wide change.

[LagradOst]

do note that I removed the cookejar from mainactivity

[PrecociouslyDigital]

ready for review!

[ghost]

@PrecociouslyDigital I tried the ao3 provider and tried to log in using the new provider settings, and it just crashed. also the search timed out.

[LagradOst]

1. DONT USE A FRAGMENT. use an alert
2. Your current code is crashing
3. Archive of our own Provider is reporting ratings higher than possible in qn you are confusing the variables, read

   QuickNovel/app/src/main/java/com/lagradost/quicknovel/MainAPI.kt

   Line 201 in 3253fbd

   data class StreamResponse(

   or just do peopleVoted = peopleVoted views = views ect
4. You use MainActivity.mainActivity everywhere, use context instead as it is a global weak reference or even activity if activity is needed

[PrecociouslyDigital]

@LagradOst I'd like to clarify; I shouldn't make provider settings a menu of its own?

[LagradOst]

@LagradOst I'd like to clarify; I shouldn't make provider settings a menu of its own?

shit forgor to reply, but I want to show an Alert for settings, it is a sort of popup so you dont take up the entire page. Here is an example in cs3. This also makes it possible to show anywhere

[PrecociouslyDigital]

Gotit; I unfortunately will be busy until August so if you or anyone else wants to make these changes I'd be delighted. If not I'll try to get this in by Aug 15th

[LagradOst]

Understandable, have a great day

[ghost]

@PrecociouslyDigital this still in progresss, if not I'll try my best to finish it. I was going to add it ages ago since I wanted to add this for my crush

[PrecociouslyDigital]

This is no longer in progress sorry. Feel free to use it as a starting point. Iirc every thing but logging in works.

…

On Wed, Dec 6, 2023, 22:21 Sir Aguacata ***@***.***> wrote: @PrecociouslyDigital <https://github.com/PrecociouslyDigital> this still in progresss, if not I'll try my best to finish it. I was going to add it ages ago since I wanted to add this for my crush — Reply to this email directly, view it on GitHub <#173 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCZPZKYJOR2W2NGOGMKSY3YIFN6XAVCNFSM6AAAAAAY5JQCUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBUGY4TCNRVHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[cheesy3097]

please add local source @LagradOst