use request set in crud instead of global request instance #4823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
I think this was a leftover from some old refactoring since we are already using the request defined in the CrudPanel in other methods, eg:
CRUD/src/app/Library/CrudPanel/CrudFilter.php
Line 111 in 77f783d
AFTER - What is happening after this PR?
I replaced the global request instances for the requests defined in CrudPanel, in the end it would fallback to the global request instance in case a request is not set in CrudPanel.
Is it a breaking change?
I don't think so no.
How can we test the before & after?
This is testable if you are manually creating a request instance and attaching it to the CrudPanel.
The global
\Request
instance has no access to this Request that we set on the CrudPanel.