remove translatable fields from casting and add tests #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
In continuation of the work on #5770
Basically since spatie introduced "auto-casts" in the translatable model, some of our functionality was broken.
We have previously fixed the issue found in the failing test suite, but we didn't had everything covered, so this one escaped us.
AFTER - What is happening after this PR?
I've now added a test for it too, and fields can be properly translated again.
HOW
How did you achieve that, in technical terms?
Added a check on our "decode" script (used for other functionalities), to not cast if the attribute is translatable.
Is it a breaking change?
No