Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated into Vietnamese #585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TanNhatCMS
Copy link

Translated into Vietnamese by TanNhatCMS

Copy link

welcome bot commented Jan 19, 2024

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

--
Justin Case
The Backpack Robot

@karandatwani92
Copy link
Contributor

Hey @TanNhatCMS

Thanks for submitting Vietnamese translations.

@pxpm I have a doubt... He just submitted a Vietnamese translation to base packages, so I find it weird to publish them in the demo again. I think translations are supposed to be automatically picked from base.

@pxpm
Copy link
Contributor

pxpm commented Jan 22, 2024

@karandatwani92 indeed, some are required to be overwritten so that we say stuff like: deleting entries in demo is disabled. and such.

But I agree with you, there are some strings that I don't think they need translation here in demo.

Can you do a review of https://github.com/Laravel-Backpack/demo/blob/main/lang/vendor/backpack/en/crud.php and cross check with the package strings, the ones we don't need to be overwriting in the demo ?

We can first delete them from the en and then update this PR to remove those strings too.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants