Repository navigation
orchestrator: take the last eCash row, use --fork - #2622
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ec70f382c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
octobocto
changed the title
ee78c2b to
2d71c07
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29c5064e0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (newestMatch == null || _compareEnforcerLogs(match, newestMatch) > 0) { | ||
| newest = file; | ||
| newestMatch = match; |
There was a problem hiding this comment.
When upgrading from the legacy layout or switching eCash forks on the same day, the old and new log directories have independent sequence numbers. For example, a legacy bip300301_enforcer.log.2026-10-27.5 outranks the newly running enforcer's bip300301_enforcer.log.2026-10-27.1, so Binary.logPath() sends the connection card's log actions to the stale file even while the new file is receiving output. Compare modification times across directories, or prefer the active fork's directory and use legacy logs only as a fallback.
Useful? React with 👍 / 👎.
BitWindow now takes the last eCash row of drivechain.dev/config as the live network, and starts the enforcer with --fork and its / folders, as LayerTwo-Labs/bip300301_enforcer#666 expects. Merge only after an enforcer release with #666, because the current enforcer has no --fork flag.