Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reachability check against v2 dispersal port #1135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Jan 22, 2025

Add v2 dispersal port reachability check

This PR depends on

V2 port not registered

{
      "operator_id": "feba99a1e3230e2383f5417ded9695f170491eb4bc2e21110d73f7f127e3d835",
      "dispersal_socket": "23.93.87.156:32005",
      "dispersal_online": true,
      "dispersal_status": "node.Dispersal is available",
      "retrieval_socket": "23.93.87.156:32004",
      "retrieval_online": true,
      "retrieval_status": "node.Retrieval is available",
      "v2_dispersal_socket": "",
      "v2_dispersal_online": false,
      "v2_dispersal_status": "v2 dispersal port is not registered"
}

V2 port registered and reachable

{
      "operator_id": "feba99a1e3230e2383f5417ded9695f170491eb4bc2e21110d73f7f127e3d835",
      "dispersal_socket": "23.93.87.156:32005",
      "dispersal_online": true,
      "dispersal_status": "node.Dispersal is available",
      "retrieval_socket": "23.93.87.156:32004",
      "retrieval_online": true,
      "retrieval_status": "node.Retrieval is available",
      "v2_dispersal_socket": "23.93.87.156:32006",
      "v2_dispersal_online": true,
      "v2_dispersal_status": "node.v2.Dispersal is available"
    }

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@pschork pschork requested a review from ian-shim January 22, 2025 04:13
@pschork pschork force-pushed the pschork/reachability_v2_alt branch 3 times, most recently from 26a82ee to dea6c04 Compare January 22, 2025 04:25
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will merge #1132 soon

```
  "operator_id": "feba99a1e3230e2383f5417ded9695f170491eb4bc2e21110d73f7f127e3d835",
  "dispersal_socket": "23.93.87.156:32005",
  "dispersal_online": true,
  "dispersal_status": "node.Dispersal is available",
  "retrieval_socket": "23.93.87.156:32004",
  "retrieval_online": true,
  "retrieval_status": "node.Retrieval is available",
  "v2_dispersal_socket": "",
  "v2_dispersal_online": false,
  "v2_dispersal_status": "v2 dispersal port is not registered"
}
```

```
  "operator_id": "feba99a1e3230e2383f5417ded9695f170491eb4bc2e21110d73f7f127e3d835",
  "dispersal_socket": "23.93.87.156:32005",
  "dispersal_online": true,
  "dispersal_status": "node.Dispersal is available",
  "retrieval_socket": "23.93.87.156:32004",
  "retrieval_online": true,
  "retrieval_status": "node.Retrieval is available",
  "v2_dispersal_socket": "23.93.87.156:32006",
  "v2_dispersal_online": true,
  "v2_dispersal_status": "node.v2.Dispersal is available"
}
```
@pschork pschork force-pushed the pschork/reachability_v2_alt branch from 0ffd330 to 69e5a8c Compare January 24, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants