Add suppport for batch feed API at dataapi #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanc
reviewed
Jan 23, 2025
disperser/dataapi/v2/server_v2.go
Outdated
| // range or "limit" param. | ||
| maxBlobFeedNumBlobs = 1000 | ||
| maxNumBlobsPerBlobfFeedResponse = 1000 |
There was a problem hiding this comment.
ah, thanks for catching it
|
|
||
| interval := 3600 | ||
| if c.Query("interval") != "" { | ||
| interval, err = strconv.Atoi(c.Query("interval")) |
There was a problem hiding this comment.
How do we handle negative interval?
There was a problem hiding this comment.
Good point to handle that, it should be invalid param error
| var err error | ||
|
|
||
| endTime := time.Now() | ||
| if c.Query("end") != "" { |
There was a problem hiding this comment.
Will it be okay if end time is past time.Now()?
There was a problem hiding this comment.
Yes, it should be fine.
dmanc
approved these changes
Jan 23, 2025
…taapibatchfeedapi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Implementing dataapi v2 (#955)
This supports the batch feed API where clients can query stream of batch in the past N seconds.
Checks