Misc documentation fix #1139
Misc documentation fix #1139
Conversation
| @@ -309,7 +309,7 @@ func BatchFromProtobuf(proto *commonpb.Batch) (*Batch, error) { | |||
| type Attestation struct { | |||
| *BatchHeader | |||
|
|
|||
| // AttestedAt is the time the attestation was made | |||
| // AttestedAt is the time the attestation was made in nanoseconds | |||
There was a problem hiding this comment.
Why not change the variable name itself to AttestedAtNano
There was a problem hiding this comment.
It's better to remain consistent with other timestamps in naming. I don't have objection if one wants to get all timestamps renamed by incorporating time units though.
disperser/dataapi/docs/v1/V1_docs.go
Outdated
There was a problem hiding this comment.
Are these all auto-generated? Might be good to add to https://github.com/Layr-Labs/eigenda/blob/master/.gitattributes if so
There was a problem hiding this comment.
we are using swagger here
| }, | ||
| "salt": { | ||
| "description": "Allow same blob to be dispersed multiple times within the same reservation period", | ||
| "type": "integer" |
There was a problem hiding this comment.
Interesting. Why were these docs not updated as part of the other PRs? Are these just hand crated? If not, should we have a ci to check that they have been regenerated correctly?
Co-authored-by: Samuel Laferriere <[email protected]>
Why are these changes needed?
Checks