Check that disperser uses correct blob length #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: litt3 <[email protected]>
cody-littley
approved these changes
Feb 19, 2025
samlaf
approved these changes
Feb 19, 2025
anupsv
reviewed
Feb 20, 2025
|
|
||
| // We need to check that the disperser used the correct length. Even once checking the commitment from the | ||
| // disperser has been implemented, there is still an edge case where the disperser could truncate trailing 0s, | ||
| // yielding the wrong blob length, but not causing commitment verification to fail. It is important that the |
There was a problem hiding this comment.
is there a change on the disperser side to make sure this case is handled ?
There was a problem hiding this comment.
I don't think so- this check is intended to protect against a disperser maliciously/incorrectly truncating 0s
anupsv
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks