feat(draft): AllocationManager redistribution support
#1346
Conversation
0xClandestine
changed the title
AllocationManager redistribution changesAllocationManager redistribution support
| /// @notice Returns the address where slashed funds will be sent for a given operator set. | ||
| /// @dev For redistributing Operator Sets, returns the configured redistribution address set during Operator Set creation. | ||
| /// For non-redistributing operator sets, returns the `DEFAULT_BURN_ADDRESS`. | ||
| mapping(bytes32 operatorSetKey => address redistributionAddr) internal _redistributionRecipients; |
There was a problem hiding this comment.
We could combine the above two mappings into an OperatorSetInfo struct? Thoughts?
There was a problem hiding this comment.
Scott had an issue with storage packing
There was a problem hiding this comment.
That's with regards to using uint96 instead of uint256. Using a struct should be fine IMO, see:
eigenlayer-contracts/src/contracts/core/DelegationManagerStorage.sol
Lines 71 to 74 in 734f736
There was a problem hiding this comment.
Why combine them if not packing?
There was a problem hiding this comment.
Less total storage slots used
There was a problem hiding this comment.
Also, if we added slashers, way easier to just have operatorSetDetails. Not blocking review rn but we should consider
| @@ -13,6 +13,8 @@ contract AllocationManagerUnitTests is EigenLayerUnitTestSetup, IAllocationManag | |||
| /// Constants | |||
There was a problem hiding this comment.
We should assert the slashCount in tests
There was a problem hiding this comment.
And add a TODO to assert shares once we add to DM
| @@ -4135,3 +4239,19 @@ contract AllocationManagerUnitTests_getAllocatedStake is AllocationManagerUnitTe | |||
| assertEq(allocatedStake[0][0], DEFAULT_OPERATOR_SHARES.mulWad(5e17), "allocated stake should remain same after deregistration"); | |||
| } | |||
| } | |||
|
|
|||
| contract AllocationManagerUnitTests_isRedistributingOperatorSet is AllocationManagerUnitTests { | |||
| function testFuzz_isRedistributingOperatorSet(Randomness r) public rand(r) { | |||
|
|
||
| OperatorSet memory redistributingOpSet = OperatorSet(defaultAVS, defaultOperatorSet.id + 1); | ||
| address redistributionRecipient = r.Address(); | ||
| _createRedistributingOperatorSet(redistributingOpSet, defaultStrategies, redistributionRecipient); |
There was a problem hiding this comment.
This test does the same as the previous AllocationManagerUnitTests_createRedistributingOperatorSets?
0xClandestine
merged commit 701c569
into
Layr-Labs:release-dev/redistribution
Motivation:
Add support for redistributing slashed funds to specified recipients instead of burning them, while optimizing code size and improving test coverage.
Modifications:
Added a new redistribution system that allows AVSs to specify recipients for slashed funds. Code optimizations were made to reduce codesize, including consolidating repeated logic and a small
PermissionControllerMixinrefactor.Result:
Slashed funds can now be redirected to specified recipients instead of being burned, with improved code efficiency and test coverage.