test: timelock queue 2 #1538
Closed
test: timelock queue 2 #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Motivation:** Previously, we stored `startBlock` and computed the `completeBlock` at runtime by iterating through the list of added strategies for a given `slashId`. This approach required recalculating the `completeBlock` each time. **Modifications:** We now store `completeBlock` directly instead of `startBlock`. During each call to `initiateSlashEscrow`, we compare the delay of the newly added strategy to the current `completeBlock` for the `slashId`. If the new delay is larger, we update `completeBlock` accordingly. This ensures that the maximum delay is always preserved. **Result:** The `completeBlock` for each `slashId` is now computed and maintained incrementally, eliminating the need for runtime iteration over all strategies.
**Motivation:** Release functions did not have a `nonReentrant` check, and while code is well isolated it would be nice to prevent the concern entirely. **Modifications:** * Applied the `nonReentrant` modifier to both `releaseSlashEscrow` and `releaseSlashEscrowByStrategy` functions within the `SlashEscrowFactory` to prevent potential reentrancy vulnerabilities. * Relocated the `nonReentrant` modifier from `clearBurnOrRedistributableShares` to `clearBurnOrRedistributableSharesByStrategy` in the `StrategyManager` to ensure both methods are protected. **Result:** Less reentrancy-based security risk.
…s#1466) **Motivation:** It was previously possible to set the redistribution recipient for a redistributing operator set to the burn address, meaning it's effectively a non-redistributing operator set. **Modifications:** - Ensure`redistributionRecipient != DEFAULT_BURN_ADDRESS`. **Result:** L-02 resolved.
**Motivation:** Missing documentation noting that an upgrade is required to rescue paused funds. **Modifications:** - Update `ISlashEscrowFactory.sol` and `SlashEscrowFactory.md`. **Result:** L-01 resolved.
**Motivation:** We've decided we do not want delays on redistributions. **Modifications:** - Removed `SlashEscrowFactory` + `SlashEscrow` and all relevant changes. **Result:** Tokens are immediately redistributed upon calling `clearBurnOrRedistributableShares`.
**Motivation:** Incorrect gap, off by one. **Modifications:** - Updated SM gap. **Result:** Correct SM gap.
**Motivation:** Test should be passing. **Modifications:** - Minor (likely rebase) error fixes. **Result:** Tests passing.
**Motivation:** We want to address a few nits. **Modifications:** - slash's -> operator set's. **Result:** Nits addressed.
**Motivation:** Want up to date changelog. **Modifications:** - Updated changelog. **Result:** Up-to-date changelog.
**Motivation:** Need updated upgrade scripts without slash escrow **Modifications:** - Remove slash escrow - Add source chain conditionals - Blacklisted eigen and beigen tokens **Result:** Working upgrade scripts --------- Co-authored-by: clandestine.eth <[email protected]>
All but 2 flakey tests are passing when running fork integration tests locally |
|
Closing now that resistro is live |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications:
Describe the modifications you've done.
Result:
After your change, what will change.