feat: remove semver + minor optimizations #1654

0xClandestine · 2025-10-09T22:47:30Z

Motivation:

We want to reduce codesize throughout our core contracts.

Modifications:

Removed SemVerMixin from every contract that doesn't inherit SignatureUtilsMixin.
Added non-revert checkCanCall function PermissionController for space savings

Result:

~300 bytes of codesize saved per contract.

ypatil12

We may not want to update the Eigen token

src/contracts/interfaces/IExtsload.sol

.size-after-commit0

src/contracts/token/Eigen.sol

nadir-akhtar

The changes to remove SemVerMixin look good from a correctness standpoint.

That said, taking a step back, I'm not sure removing SemVerMixin for the 300 bytes return is ideal. It's a strange property for some contracts to have a version attributed to them, and for others not to.

If we're to make a change here, I recommend we have some replacement, e.g. a registry with either a global protocol version or versions for each contract. That way, we don't have a strange situation where some contracts have version while others don't.

nadir-akhtar · 2025-10-25T02:46:51Z

src/contracts/core/AllocationManager.sol

    ) external onlyWhenNotPaused(PAUSED_MODIFY_ALLOCATIONS) {
        // Check that the caller is allowed to modify allocations on behalf of the operator
        // We do not use a modifier to avoid `stack too deep` errors
-        require(_checkCanCall(operator), InvalidCaller());


Curious to know what the need for these changes to the PermissionControllerMixin and related contracts was in this PR is, as it seems unrelated to the SemVerMixin. We lose some granularity in error specification here -- not the worst situation as InvalidPermissions is fairly explanatory for a given function, but recommend we save this for a different PR.

srry squashed, commit history not as useful now

Do we still have this update in this PR?

ypatil12 · 2025-11-04T22:00:56Z

src/contracts/core/AllocationManager.sol


        // If we're not newly registered, check that the caller (not the delegationManager) is authorized to set the allocation delay for the operator
        if (!newlyRegistered) {
-            require(_checkCanCall(operator), InvalidCaller());


Why not use require(_canCall() here? When would we use _checkCanCall as opposed to require(_canCall())?

How much do we save? IMO not worth to have two different patterns of use within the same contract (or even across the protocol). We also do canCall not in a modifier below:

eg.

eigenlayer-contracts/src/contracts/core/AllocationManager.sol

Line 214 in 87ae910

require(_canCall(params.operator) || _canCall(params.avs), InvalidCaller());

**Motivation:** The `AllocationManager` contract was hitting the 24KB bytecode size limit, which would have blocked deployment. We needed a solution to reduce the contract size while maintaining backwards compatibility with existing integrations that call view functions on `AllocationManager`. **Modifications:** - Created a new `SplitContractMixin` that uses a fallback to delegate unmatched function calls via `delegatecall` to a secondary contract - Split `AllocationManager` into two contracts: the main contract handles state-mutating operations, while `AllocationManagerView` handles all read-only view functions - Both contracts inherit from `AllocationManagerStorage` to share the same storage layout, enabling the view contract to read from the main contract's storage - Updated `AllocationManager` constructor to accept and store the `AllocationManagerView` address - Modified all deployment scripts (devnet, local, integration) to deploy both proxies and implementations - Updated `ExistingDeploymentParser`, test harnesses, and unit/integration tests to work with the split architecture **Result:** - The `AllocationManager` is now about ~ 4.8KB under the 24KB limit with room to grow. - The `AllocationManagerView` contract has 16KB of available space for future view functions. TODO: Add a ci check (I don't have privs but the code is written locally) 1) Get list of all contracts ending in View.sol in the repo. 2) Use forge inspect abi and check all mutability fields == view|pure. 3) Basic search over the file to see if sstore or delegatecall is used on a for additional sanity. --------- Co-authored-by: eigenmikem <[email protected]> squash squash feat: split alm wip wip wip wip wip wip wip unit tests passing remove extsload wip tests passing chore: git mv storage to folder wip ci docs todo cleanup ci ci rename `secondHalf` rm extsload move storage add protocol registry to zeus squash feat: split alm wip wip wip wip wip wip wip unit tests passing remove extsload wip tests passing chore: git mv storage to folder wip ci wip wip wip wip wip remove extsload wip tests passing wip passing perf: wrap modifier logic to save codesize chore: forge fmt refactor: remove semver (#1641) **Motivation:** We want to consolidate semver logic into a single purpose built contract. **Modifications:** - Removed `SemVerMixin` import from all contracts. **Result:** More codesize savings. make fmt refactor: expand `ProtocolRegistry` to list all contracts + pause rm gas snapshots rm extsload rebase ci revert eigen changes remove stale scripts

**Motivation:** We want to reduce codesize throughout our core contracts. **Modifications:** - Removed `SemVerMixin` from every contract that doesn't inherit `SignatureUtilsMixin`. - Added non-revert `checkCanCall` function `PermissionController` for space savings **Result:** ~300 bytes of codesize saved per contract. --------- Co-authored-by: Yash Patil <[email protected]>

0xClandestine changed the title ~~feat: add ProtocolRegistry + one-click pause all~~ feat: add ProtocolRegistry + remove semver Oct 9, 2025

0xClandestine force-pushed the perf/codesize branch from 7cc2203 to e23d5c9 Compare October 9, 2025 23:01

0xClandestine changed the title ~~feat: add ProtocolRegistry + remove semver~~ feat: remove semver + minor optimizations Oct 9, 2025

0xClandestine force-pushed the refactor/split-alm branch 3 times, most recently from 42af1f1 to ecc69cf Compare October 16, 2025 15:14

0xClandestine force-pushed the perf/codesize branch from fb163fb to 54b1047 Compare October 16, 2025 15:24

0xClandestine requested a review from ypatil12 October 16, 2025 15:28

ypatil12 reviewed Oct 16, 2025

View reviewed changes

src/contracts/interfaces/IExtsload.sol Outdated Show resolved Hide resolved

.size-after-commit0 Outdated Show resolved Hide resolved

ypatil12 reviewed Oct 16, 2025

View reviewed changes

src/contracts/token/Eigen.sol Outdated Show resolved Hide resolved

0xClandestine force-pushed the perf/codesize branch from fbcb025 to d60643a Compare October 16, 2025 20:24

Base automatically changed from refactor/split-alm to release-dev/slashing-ux-improvements October 23, 2025 20:01

0xClandestine force-pushed the perf/codesize branch 2 times, most recently from be7c1dc to d17a568 Compare October 24, 2025 16:17

nadir-akhtar reviewed Oct 25, 2025

View reviewed changes

0xClandestine requested a review from nadir-akhtar November 3, 2025 19:38

ypatil12 reviewed Nov 4, 2025

View reviewed changes

ypatil12 approved these changes Nov 5, 2025

View reviewed changes

ypatil12 force-pushed the perf/codesize branch from 4830de3 to c1caa7d Compare November 5, 2025 20:06

0xClandestine and others added 9 commits November 5, 2025 15:08

chore: fix ci

3fa2bc8

chore: add hoodi rpc

ee327da

fix: test

5d89424

fix: use base for crosschain test

c942c74

fix: test

c1f22c4

test: split up crosschainlib

1caf250

chore: skip

0c6969e

chore: fmt

96e51bc

ypatil12 force-pushed the perf/codesize branch from c1caa7d to 96e51bc Compare November 5, 2025 20:08

fix: compile

5ad15da

ypatil12 and others added 2 commits November 5, 2025 15:23

chore: remove unnecessary diff

992179b

docs: clarify mixin usage

e9c7788

ypatil12 merged commit 090df60 into release-dev/slashing-ux-improvements Nov 5, 2025
16 checks passed

ypatil12 deleted the perf/codesize branch November 5, 2025 20:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: remove semver + minor optimizations #1654

feat: remove semver + minor optimizations #1654

Uh oh!

0xClandestine commented Oct 9, 2025 •

edited by ypatil12

Loading

Uh oh!

ypatil12 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nadir-akhtar left a comment

Uh oh!

nadir-akhtar Oct 25, 2025

Uh oh!

0xClandestine Oct 28, 2025

Uh oh!

ypatil12 Nov 4, 2025

Uh oh!

ypatil12 Nov 4, 2025

Uh oh!

0xClandestine Nov 4, 2025

Uh oh!

ypatil12 Nov 5, 2025 •

edited

Loading

Uh oh!

ypatil12 Nov 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: remove semver + minor optimizations #1654

feat: remove semver + minor optimizations #1654

Uh oh!

Conversation

0xClandestine commented Oct 9, 2025 • edited by ypatil12 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ypatil12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nadir-akhtar left a comment

Choose a reason for hiding this comment

Uh oh!

nadir-akhtar Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

0xClandestine Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

ypatil12 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

ypatil12 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

0xClandestine Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

ypatil12 Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ypatil12 Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

0xClandestine commented Oct 9, 2025 •

edited by ypatil12

Loading

ypatil12 Nov 5, 2025 •

edited

Loading