Skip to content

refactor: common error interface for avsRegistry chainReader #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c1b0717
Create a test reader for avsregistry
damiramirez Jan 22, 2025
7ebbb37
Add test case for reader when config is invalid
damiramirez Jan 22, 2025
8b2c876
Add more methods with invalid config
damiramirez Jan 22, 2025
012c7b1
Add test for GetOperatorsStakeInQuorumsOfOperator
damiramirez Jan 22, 2025
1c19f19
Remove t.Log
damiramirez Jan 22, 2025
fc2b46c
Refactor in operators stake in quorums
damiramirez Jan 22, 2025
755148a
Add case for QueryExistingRegisteredOperatorPubKeys
damiramirez Jan 22, 2025
d45e700
Merge branch 'dev' into test/avsregistry-reader
damiramirez Jan 22, 2025
c86b82f
Change helper function name
damiramirez Jan 22, 2025
3b6baca
Add error interface from #477
maximopalopoli Jan 29, 2025
6cb60be
Merge branch 'dev' into refactor/error-interface-avsregistry-reader
maximopalopoli Jan 29, 2025
4bdffb6
Use missing contract custom error and tag errors with comments
maximopalopoli Jan 29, 2025
e8c1131
Use custom binding error in binding calls failures
maximopalopoli Jan 29, 2025
d7c55f1
Use existent custom errors to cover all cases
maximopalopoli Jan 29, 2025
0062953
Fix err description asserts
maximopalopoli Jan 29, 2025
adf5b2e
Merge branch 'test/avsregistry-reader' into refactor/error-interface-…
maximopalopoli Jan 30, 2025
0745274
Add expected error message assert
maximopalopoli Jan 30, 2025
ed5ae28
Merge branch 'dev' into refactor/error-interface-avsregistry-reader
maximopalopoli Jan 30, 2025
d879a4b
Merge branch 'dev' into refactor/error-interface-avsregistry-reader
maximopalopoli Feb 3, 2025
0d1aa10
Make changes on error struct
maximopalopoli Feb 17, 2025
0ea7391
Use creation functions new names in reader
maximopalopoli Feb 17, 2025
c0e518e
Rename contracts according to solidity convention
maximopalopoli Feb 17, 2025
c7687c1
Change literal error equal assert for an ErrorContains
maximopalopoli Feb 17, 2025
2d5fac9
Merge branch 'dev' into refactor/error-interface-avsregistry-reader
maximopalopoli Feb 17, 2025
e9096b9
Use MissingContractError abstraction in new functions
maximopalopoli Feb 17, 2025
0c85379
Use BindingError abstraction for errors at request for binding
maximopalopoli Feb 17, 2025
f06d3b5
Merge branch 'dev' into refactor/error-interface-avsregistry-reader
maximopalopoli Feb 17, 2025
0c69b39
Add change and example to changelog
maximopalopoli Feb 17, 2025
a37dbb5
Fix changelog example
maximopalopoli Feb 17, 2025
77e7ad0
Merge branch 'dev' into refactor/error-interface-avsregistry-reader
maximopalopoli Feb 18, 2025
58afb99
Merge branch 'dev' into refactor/error-interface-avsregistry-reader
maximopalopoli Feb 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,16 @@ Each version will have a separate `Breaking Changes` section as well. To describ
* fix: change requested pr url in changelog's workflow by @maximopalopoli in <https://github.com/Layr-Labs/eigensdk-go/pull/575>

### Breaking changes
* refactor: add custom error struct in avs registry reader methods by @maximopalopoli in <https://github.com/Layr-Labs/eigensdk-go/pull/486>
* The errors now follow this format: `error name (error code) - error description: underlying error`.

For example, in this code section:
```go
if r.serviceManager == nil {
wrappedError := elcontracts.MissingContractError("ServiceManager")
return nil, wrappedError
}
```
The returned error if err is not nil would be `Missing needed contract (1) - ServiceManager contract not provided` (this error type has no underlying error)

### Removed
Loading
Loading