Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added setMinimumStakeForQuorum #554

Merged
merged 6 commits into from
Feb 11, 2025
Merged

added setMinimumStakeForQuorum #554

merged 6 commits into from
Feb 11, 2025

Conversation

Sidu28
Copy link
Contributor

@Sidu28 Sidu28 commented Feb 11, 2025

Fixes # .

What Changed?

Added support for setMinimumStakeForQuorum function.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@Sidu28 Sidu28 marked this pull request as ready for review February 11, 2025 16:46
@Sidu28 Sidu28 requested a review from MegaRedHand February 11, 2025 16:47
MegaRedHand
MegaRedHand reviewed Feb 11, 2025
View reviewed changes
chainio/clients/avsregistry/writer_test.go Outdated Show resolved Hide resolved
chainio/clients/avsregistry/writer_test.go Outdated Show resolved Hide resolved
chainio/clients/avsregistry/writer_test.go Outdated Show resolved Hide resolved
MegaRedHand
MegaRedHand previously approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nitpicks. Apart from that, LGTM

@Sidu28 Sidu28 requested a review from MegaRedHand February 11, 2025 18:24
@Sidu28 Sidu28 enabled auto-merge February 11, 2025 18:24
@MegaRedHand MegaRedHand disabled auto-merge February 11, 2025 18:25
@MegaRedHand MegaRedHand added this pull request to the merge queue Feb 11, 2025
Merged via the queue into dev with commit 45d9e05 Feb 11, 2025
11 checks passed
@MegaRedHand MegaRedHand deleted the stake-registry-write-functions branch February 11, 2025 18:32
@MegaRedHand MegaRedHand mentioned this pull request Feb 12, 2025
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sidu28 @MegaRedHand