Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing contract addresses on BuildAllConfig #558

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

MegaRedHand
Copy link
Contributor

@MegaRedHand MegaRedHand commented Feb 11, 2025

Fixes # .

What Changed?

This PR adds PermissionController and RewardsCoordinator addresses to the BuildAllConfig. It also sets these new fields in the StartAnvilContainer function to make them available and registers the PermissionController in the ContractRegistry so we can remove an address constant we had.

This also modifies the "bindings" workflow to ignore changes to deploy scripts, since those don't modify interfaces, and thus, bindings.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@MegaRedHand MegaRedHand self-assigned this Feb 11, 2025
@MegaRedHand MegaRedHand added this pull request to the merge queue Feb 12, 2025
Merged via the queue into dev with commit 5adc7a7 Feb 12, 2025
11 checks passed
@MegaRedHand MegaRedHand deleted the add-missing-contract-addresses-for-tests branch February 12, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants