fix install #294
LeChatPAnnotations
1 error and 11 warnings
|
build
Process completed with exit code 127.
|
|
this `impl` can be derived:
rar-common/src/lib.rs#L192
warning: this `impl` can be derived
--> rar-common/src/lib.rs:192:1
|
192 | / impl Default for RemoteStorageSettings {
193 | | fn default() -> Self {
194 | | Self {
195 | | immutable: None,
... |
205 | | }
206 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it
|
110 + #[derive(Default)]
111 | pub struct RemoteStorageSettings {
|
|
|
the following explicit lifetimes could be elided: 'de:
rar-common/src/database/structs.rs#L345
warning: the following explicit lifetimes could be elided: 'de
--> rar-common/src/database/structs.rs:345:14
|
345 | impl<'de> Visitor<'de> for IdVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
345 - impl<'de> Visitor<'de> for IdVisitor {
345 + impl Visitor<'_> for IdVisitor {
|
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
rar-common/src/database/finder.rs#L706
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> rar-common/src/database/finder.rs:706:91
|
706 | let min = PluginManager::notify_user_matcher(&as_borrow!(self), user, &element);
| ^^^^^^^^ help: change this to: `element`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
rar-common/src/database/finder.rs#L491
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> rar-common/src/database/finder.rs:491:47
|
491 | SGroups::Single(group) => is_root(&group),
| ^^^^^^ help: change this to: `group`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
writing `&String` instead of `&str` involves a new object where a slice will do:
rar-common/src/database/finder.rs#L326
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> rar-common/src/database/finder.rs:326:27
|
326 | fn match_path(input_path: &String, role_path: &String) -> CmdMin {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
unused variable: `tool`:
rar-common/src/util.rs#L258
warning: unused variable: `tool`
--> rar-common/src/util.rs:258:17
|
258 | pub fn subsribe(tool: &str) -> Result<(), Box<dyn Error>> {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_tool`
|
= note: `#[warn(unused_variables)]` on by default
|
|
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|