Skip to content

Add helpers to reproduce prod issues#166

Open
fbeutin-ledger wants to merge 1 commit intodevelopfrom
fbe/helpers
Open

Add helpers to reproduce prod issues#166
fbeutin-ledger wants to merge 1 commit intodevelopfrom
fbe/helpers

Conversation

@fbeutin-ledger
Copy link

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds build-time “bypass” helpers intended to reproduce production issues by disabling certain validation checks (trusted-name challenge verification and signer presence checks), plus a small repo ignore helper for a local swap test script.

Changes:

  • Add compile-time bypasses for signer index lookup failure and trusted-name challenge mismatch.
  • Add a new ledger_app.toml use case to enable these bypasses, and Makefile wiring to pass the defines.
  • Ignore a local helper file (tests/swap/test_raw.py) via .gitignore.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/handle_sign_message.c Adds optional bypass when signer pubkey index lookup fails.
src/handle_provide_trusted_info.c Adds optional bypass when the trusted-name challenge does not match.
ledger_app.toml Adds a prog_reproduce use-case enabling the bypass flags.
Makefile Adds Make variables to define the bypass flags at compile time.
.gitignore Adds ignore rule for a local APDU replay helper script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants