Open
Conversation
322fb8b to
c29cf81
Compare
4fdbf49 to
e251c4d
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds build-time “bypass” helpers intended to reproduce production issues by disabling certain validation checks (trusted-name challenge verification and signer presence checks), plus a small repo ignore helper for a local swap test script.
Changes:
- Add compile-time bypasses for signer index lookup failure and trusted-name challenge mismatch.
- Add a new
ledger_app.tomluse case to enable these bypasses, and Makefile wiring to pass the defines. - Ignore a local helper file (
tests/swap/test_raw.py) via.gitignore.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/handle_sign_message.c |
Adds optional bypass when signer pubkey index lookup fails. |
src/handle_provide_trusted_info.c |
Adds optional bypass when the trusted-name challenge does not match. |
ledger_app.toml |
Adds a prog_reproduce use-case enabling the bypass flags. |
Makefile |
Adds Make variables to define the bypass flags at compile time. |
.gitignore |
Adds ignore rule for a local APDU replay helper script. |
e251c4d to
d6a8055
Compare
d6a8055 to
eb584ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.