Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements support for V1 offchain message signing by extending the message signing infrastructure to handle both V0 (with application domain and format byte) and V1 (without these fields) message formats.
Changes:
- Added V1 offchain message format support alongside existing V0 format
- Enhanced UI to show blind signing warnings for non-ASCII UTF-8 messages
- Refactored Python test helpers to support blind signing navigation flows
Reviewed changes
Copilot reviewed 8 out of 1371 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/python/navigation_helper.py | Added blind signing navigation helpers and streamlined existing settings functions |
| tests/application_client/solana_cmd_builder.py | Separated V0 and V1 message builders with distinct serialization logic |
| src/ui/sign_message_nbgl.c | Renamed static variables to G_ prefix and added blind signing UI for non-ASCII messages |
| src/handle_sign_offchain_message.c | Added V1 message validation and refactored UI setup to handle both versions |
| src/apdu.h | Added message_text pointer to track message content offset |
| libsol/parser.c | Implemented conditional parsing for V0 vs V1 header formats |
| libsol/include/sol/parser.h | Added helper function to compute header length based on version |
| .github/copilot-instructions.md | Updated testing and UI guidelines |
fbeutin-ledger
force-pushed
the
develop
branch
from
322fb8b to
c29cf81
Compare
fbeutin-ledger
force-pushed
the
fbe/message_signing_v1
branch
from
7eb5129 to
f51d6a0
Compare
fbeutin-ledger
force-pushed
the
fbe/message_signing_v1
branch
from
f51d6a0 to
afa28f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.