fix: Out-of-bounds read in INS_SIGN freeze/unfreeze receiver handling via strlen on binary address - #96
Open
cerberus-production[bot] wants to merge 1 commit into
Open
Conversation
… via strlen on binary address
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated security fix for Out-of-bounds read in INS_SIGN freeze/unfreeze receiver handling via strlen on binary address (High).
CWE: CWE-CWE-125
OWASP: A03:2021-Injection
Fix Confidence: high
What Changed
Replaced two
strlen((const char *) txContent.destination) > 0checks withmemcmp(txContent.destination, ZERO_ADDRESS, ADDRESS_SIZE) != 0. Thedestinationfield is a 21-byte binary Tron address (not NUL-terminated), so usingstrlen()causes an out-of-bounds read past the buffer. A static const zero-filled arrayZERO_ADDRESSis used to compare against, which correctly detects whether a receiver address was set.Caveats
Verification Checklist
Created by Cerberus Merlin