Cuda option to control initial graph capture - #2416
Open
Menkib64 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new capture_graphs_onload CUDA/cuDNN backend option that lets users skip the expensive constructor-time CUDA graph preallocation (graphs will still be captured lazily on first use via ComputeBlocking). Also tweaks the preallocation loop's starting index from 0 to 1, so the captured batch sizes are 1..GetMiniBatchSize() rather than 1..GetMiniBatchSize()+1.
Changes:
- New
capture_graphs_onloadoption (defaulttrue) gating the on-load graph preallocation block in both CUDA and cuDNN backends. - Loop start index changed from
0to1to avoid over-capturing one extra batch size beyondGetMiniBatchSize().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/neural/backends/cuda/network_cuda.cc | Add early return on capture_graphs_onload=false; fix preallocation loop range. |
| src/neural/backends/cuda/network_cudnn.cc | Same change applied to cuDNN backend. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.