Add opening seed control for selfplay opening randomness - #2423
Open
john-sp wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds deterministic control over selfplay opening selection by introducing a dedicated RNG seed (--opening-seed) used only for opening-book shuffling and random opening selection, while leaving the existing global RNG behavior unchanged for other tournament randomness.
Changes:
- Add
--opening-seed(default-1) to control randomness for--openings-mode=shuffledand--openings-mode=random. - Introduce a new
Random(int seed)constructor that preserves current non-deterministic seeding for negative seeds. - Use a per-tournament
opening_random_RNG for opening shuffle/selection instead ofRandom::Get().
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/utils/random.h | Exposes a seeded Random(int seed) constructor to support deterministic RNG instances. |
| src/utils/random.cc | Implements seeded initialization (negative seed preserves current non-deterministic behavior). |
| src/selfplay/tournament.h | Adds a dedicated opening_random_ member RNG for opening-related randomness. |
| src/selfplay/tournament.cc | Adds --opening-seed, initializes opening_random_, and switches shuffled/random opening logic to use it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Menkib64
reviewed
Jun 29, 2026
Menkib64
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new selfplay flag, --opening-seed, to control randomness used by shuffled and random opening modes.
Changes: