Make Description because empty by default

This will reduce redundant code
Lendable · Oct 1, 2023 · 7752021 · 7752021
1 parent fce550e
commit 7752021
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Expression/Description.php b/src/Expression/Description.php
@@ -9,7 +9,7 @@ class Description
     /** @var string */
     private $description;
 
-    public function __construct(string $description, string $because)
+    public function __construct(string $description, string $because = '')
     {
         $this->description = $description;
 

diff --git a/tests/Unit/Expressions/DescriptionTest.php b/tests/Unit/Expressions/DescriptionTest.php
@@ -11,7 +11,7 @@ class DescriptionTest extends TestCase
 {
     public function test_it_should_return_description(): void
     {
-        $description = new Description('an example', '');
+        $description = new Description('an example');
         self::assertEquals('an example', $description->toString());
     }
 

diff --git a/tests/Unit/Rules/ConstraintsTest.php b/tests/Unit/Rules/ConstraintsTest.php
@@ -21,7 +21,7 @@ public function test_it_should_not_add_to_violation_if_constraint_is_not_violate
         $trueExpression = new class() implements Expression {
             public function describe(ClassDescription $theClass, string $because = ''): Description
             {
-                return new Description('', '');
+                return new Description('');
             }
 
             public function evaluate(ClassDescription $theClass, Violations $violations, string $because = ''): void