feat: add doctrine/dbal DateType
#907
Draft
+345
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmichalski
force-pushed
the
dbal-date-type
branch
from
d5af50b to
b4363c9
Compare
|
My first personal impression is that we should use a separate repository for storage type mappings. Lendable doctrine types would focus on single purpose and we could focus here on date without storage dependencies. Feel free to ignore my comment or share your ideas. |
Member
martin-georgiev
left a comment
martin-georgiev
left a comment
There was a problem hiding this comment.
Can you extend the tests to validate against postgresql too, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.