Implement has() and hasMany()
#111
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support of two methods:
```js
await db.put('love', 'u')
await db.has('love') // true
await db.hasMany(['love', 'hate']) // [true, false]
```
Depends on a pending `abstract-level` release, and lacks support of
explicit snapshots which should be implemented after #110 lands.
Ref: Level/community#142
vweevers
added
enhancement
7 tasks
vweevers
commented
Dec 29, 2024
|
|
||
| for (const std::string& key: keys_) { | ||
| std::string value; | ||
| leveldb::Status status = database_->Get(options_, key, value); |
There was a problem hiding this comment.
It might be faster to use an iterator (if the LevelDB iterator lazily reads values thus allowing us to skip that; not sure) but it would add some complexity so I'll save that for a future PR (or for anyone who wants to take a stab at that).
There was a problem hiding this comment.
Get() copies the value while an iterator would not. So should indeed use an iterator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support of two methods:
Depends on a pending
abstract-levelrelease, and lacks support of explicit snapshots which should be implemented after #110 lands.Ref: Level/community#142