Merged
Conversation
- Added logic to manage local reactions based on incoming reaction events, allowing for immediate UI updates. - Introduced a mechanism to apply reactions optimistically and save the state if successful. - Enhanced error logging for cases where local reaction application is skipped, improving debugging capabilities.
…se management - Moved the transaction response check for sending reaction messages to a more logical position in the code. - Restored error logging for failed reaction message sends, enhancing debugging capabilities. - Removed unnecessary state saving before the transaction response check to streamline the process.
- Introduced a new UI component for displaying message reactions, enhancing user interaction within chat messages. - Updated the logic to apply pending reactions and trigger chat modal updates when reactions are applied. - Enhanced CSS styles for reaction chips to improve visual presentation and layout consistency. - Added functionality to manage and display reactions based on user ownership, improving clarity in chat interactions.
- Introduced normalization for user and contact addresses to streamline reaction processing. - Refactored the logic for displaying message reactions, improving clarity and ownership representation. - Updated CSS by removing unnecessary styles for contact reactions, focusing on user-specific reaction styling.
- Removed visibility state check before appending the chat modal, ensuring it is displayed regardless of the document's visibility state when a pending reaction is applied. - Streamlined the logic for showing the chat modal during reaction processing, enhancing user experience in chat interactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR opens
phase4-render-reactionsagainstmainso the chat reaction work can be reviewed from the default branch.What changed
ChatModalWhy
The reaction rollout needs the chat UI layer that actually shows stored reaction state to users.
Impact
Because
maindoes not yet contain the prerequisite phase 3 reaction commits from this branch, this PR currently includes both:Validation
phase4-render-reactionsagainstmain