[DNM] Add page titles for public catalog #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Parking this one here for now, in case someone has time to put eyes on it. Hopefully the above style of change-log is easy to follow. It doesn't feel right to actually deploy until Archive is fully up (soon!), and admins have caught up on our back-log of projects. I'll post back, and also change the title, at that time. 😓 |
Update `application/views/catalog/partials/header.php` Replaced just "LibriVox" as the HTML->head->title with the following: `<page title> | LibriVox` Update `application/controllers/catalog/*` Set titles for the following types of pages: * Author pages: Works by \<author name> * Group pages: Works in "\<group name>" (including quotes) * Project pages: \<book/project title> * Reader pages: Works read by \<reader name> * "Reader section details" sub-pages: Section details for \<reader name> Any other pages (various search/browse pages that use the Search controller), will default to "Browse catalog". Update `application/views/catalog/page.php` Use the title that was generated from the Page controller, instead of calling that helper again from here.
Add page titles to `application/controllers/`. As with the catalog,
each will have " | LibriVox" tacked on the end.
* Auth: Login
* admin/Author_manager: Author Manager
* admin/Genre_manager: Genre Manager
* admin/Language_Manager: Language Manager
* private/Administer_projects:
[ \<project title\> | ] Project Screen
* private/Groups: Group Manager
* private/Projects: \<'My projects' or 'Search projects'\>
* private/Section_Compiler:
<'Select a project' or project title\> | Section Compiler
* private/Stats.php - each as titled in the menu, aside from the index,
which is not linked in the menu and does not appear to be implemented.
* private/Validator:
\<'Select a project' or project title\> | Validator
* private/Volunteers: Search Users
Note: this includes all of the links under the 'People' menu, except for
'Add New'.
* public/Home (aka `/workflow` landing page): Workflow Tool
* public/Project_launch:
\<'Project template generator' or 'Template results page'\>
* public/Uploader: Upload files
New file `application/views/common/workflow_head.php`, to load the
`page_title` into an HTML->head->title element.
redrun45
force-pushed
the
catalog-titles
branch
from
1333c3c to
a9344d5
Compare
|
Pulling this one for now, to clear up the PR list. I'll re-submit after I've got the admin OK, and after I've added titles for the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
application/views/catalog/partials/header.php(last on the list, in GitHub's UI)Replaced just "LibriVox" as the HTML->head->title with the following:
<page title> | LibriVoxUpdate
application/controllers/catalog/*Set titles for the following types of pages:
Any other pages (various search/browse pages that use the Search
controller), will default to "Browse catalog".
Update
application/views/catalog/page.php(Second-to-last)Use the title that was generated from the Page controller, instead of
calling that helper again from here.