Fix mypy errors attributed to pytorch_lightning.demos.boring_classes
#14201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnakalyan3
requested review from
carmocca,
justusschock,
williamFalcon,
Borda,
tchaton,
awaelchli,
kaushikb11 and
rohitgr7
as code owners
There was a problem hiding this comment.
Hey @krishnakalyan3 ,
thanks for the PR!
However, just slapping Any on every single type is not what we want to achieve here. We actually want meaningful types. I corrected a whole bunch of them. Would you mind resolving the others (and add missing imports)?
awaelchli
approved these changes
Aug 15, 2022
|
Thanks for the feedback @justusschock. |
carmocca
reviewed
Aug 17, 2022
rohitgr7
approved these changes
Aug 17, 2022
otaj
approved these changes
Aug 22, 2022
added 2 commits
August 22, 2022 11:13
mergify
bot
added
ready
|
Thanks, @otaj. I should have checked the asserts. |
carmocca
approved these changes
Aug 22, 2022
auto-merge was automatically disabled
August 22, 2022 12:09
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13445