-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix warning frequency in throughput monitor callback #21453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning frequency in throughput monitor callback #21453
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #21453 +/- ##
=========================================
- Coverage 87% 79% -8%
=========================================
Files 270 267 -3
Lines 24059 24006 -53
=========================================
- Hits 20855 18954 -1901
- Misses 3204 5052 +1848 |
deependujha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the changelog too.
# Conflicts: # src/lightning/pytorch/CHANGELOG.md
What does this PR do?
Fixes #21450
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21453.org.readthedocs.build/en/21453/