Skip to content

Conversation

@GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Dec 28, 2025

What does this PR do?

Fixes #21450

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21453.org.readthedocs.build/en/21453/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 28, 2025
@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (9df1910) to head (53c1240).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (9df1910) and HEAD (53c1240). Click for more details.

HEAD has 717 uploads less than BASE
Flag BASE (9df1910) HEAD (53c1240)
cpu 196 33
python 18 3
lightning_fabric 53 0
pytest 98 0
python3.12 53 9
python3.10 18 3
lightning 90 15
python3.12.7 54 9
python3.11 36 6
python3.13 17 3
pytorch2.2.2 9 3
pytest-full 98 33
pytorch2.8 18 6
pytorch_lightning 53 18
pytorch2.4.1 9 3
pytorch2.1 18 6
pytorch2.7 9 3
pytorch2.6 9 3
pytorch2.3 9 3
pytorch2.9 8 3
pytorch2.5.1 9 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21453     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         270      267      -3     
  Lines       24059    24006     -53     
=========================================
- Hits        20855    18954   -1901     
- Misses       3204     5052   +1848     

Copy link
Collaborator

@deependujha deependujha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog too.

# Conflicts:
#	src/lightning/pytorch/CHANGELOG.md
@deependujha deependujha added ready to be merged PRs ready to be merged and removed ready to be merged PRs ready to be merged labels Jan 13, 2026
@tchaton tchaton merged commit aa0ee0d into Lightning-AI:master Jan 14, 2026
124 of 127 checks passed
@GdoongMathew GdoongMathew deleted the fix/fix_spamming_warning_throughput branch January 14, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package ready to be merged PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Throughput monitor spamming flops_per_batch missing warning

3 participants