-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix RichModelSummary model size display #21467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix RichModelSummary model size display #21467
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #21467 +/- ##
=========================================
- Coverage 87% 79% -8%
=========================================
Files 270 267 -3
Lines 24059 24005 -54
=========================================
- Hits 20855 18953 -1902
- Misses 3204 5052 +1848 |
bhimrazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test ?
4a9d305 to
3c49304
Compare
What does this PR do?
RichModelSummaryincorrectly passedmodel_size(already in MB) toget_human_readable_count(), which converts numbers to K/M/G format. This resulted in misleading output like "5.5 K" instead of the actual size "5,500.000".Now uses
get_formatted_model_size()for consistency withModelSummary.Before submitting
📚 Documentation preview 📚: https://pytorch-lightning--21467.org.readthedocs.build/en/21467/